From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1168F39A7E8 for ; Fri, 27 Feb 2026 22:01:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229708; cv=none; b=pD5YDnTeDfSJXFauvG9/XNKnS+jIGFxcezAlJ5iZk0ZjxhPryvr4L6X7s2XSYH5ND1uNoHhCfyhfgXVpOjmZe5cJ/0cFXseSVFI/wO/o211Eim9pnsQHGI6darKlmY9BPNex8vycJ438P8mb41YRCuCOOc7pg9ygJp5D4MOb170= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229708; c=relaxed/simple; bh=CYiYTnwNeylMM0HbpSCJXpVAz606/Y7ZTGFMvbESAo8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=RILxrjDY443Yr9QaCa4QAWeiqfnaa2KDDLadwOkARYNryN071CpJmDm2A67hJOrnMePBuHZzM5RBz6S76aaYMaXP5jLzihsmHh7t7ipzkmBRyBC18ibcFEAR/pcyCu8CJ16z45Id4XwhUvi9JkmE9elj2mLhXItsDt4QFAjOLIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fEUsjCDK; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fEUsjCDK" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4806bf39419so26248055e9.1 for ; Fri, 27 Feb 2026 14:01:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772229705; x=1772834505; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=NEj5z+HJgfkEBXGLmrIy+Ao12OFPZ4vXhdTKA40MjjI=; b=fEUsjCDKdQd+A9YGjFXnYtJ91HQavAA0C5DBCIaWLTyEvM3pWBVGAmjDe+YEyscQfP YbolqM7YZF85dxd09M8Ym6jLAJlIPOVuKijBcf8pExpZu0ExWewsbHiH1oVVV0XTqFGQ FFhcXk2ldOuzIKYPo1FJEF4BU/pnkCO8uFRbPXolYOA4pyNJtjCEDFL93KuKkqGA4G4g YdMvqXvuDio5DqluqupVnpIoZGTurETOPQPh9zrlnM6ZRFkFUPvSBOdtiWv4VwvP6wS1 AmcHiRHIfAiPI124JUQIT3+6Q5+dhlaxgpXPUBlzPSuga/6rlI8AEulX8thw2XQxlkxq uuUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772229705; x=1772834505; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NEj5z+HJgfkEBXGLmrIy+Ao12OFPZ4vXhdTKA40MjjI=; b=stAAYwylJxSYRRF3h5Ulxg5UGcjuqRHQXjFr6ZwS/fHZEYcoF4KeuRpx9Z5RK4EIu0 3h/wmU3n5l6JQ8rsO9slmaR4kyjavKYOXRM+DT8LDPpx+DtV+07Dms2P03rOCUIGDqHd 6o3wtYHN9/1qtXXw1z9QdX/hVgHeaCBkSus0GVoQrv6WGRPBUTFERn1KzFnwou8gVDD3 vcT/SirPA566LFk4Dxz/TaE0jdIX16iIyJyqaLmN/OHswCKlX/wD1XvMse2q1gOXE1NA sgkBHp1YKBiaF34j7vl7OYBDd8s3jG5LSt6zlN6qhX2KeUt02EcS+LyV3DSDaarcYRuW PsEA== X-Forwarded-Encrypted: i=1; AJvYcCW3ol8ObdMdkhGXRpbPPvZHheMRy8VkO5oMDlfKKyzluLTwJ7+Uc+E/S0jQiRjVOuSRoG8w/qnCmbVeZyk=@vger.kernel.org X-Gm-Message-State: AOJu0YyEEAb4lG50BLafeG3zFQ5ey8gjKBkrLuayEPZHru+oSPsRTPUD Ikbom8KuaBCF/u1aVnMb0/UVbiREzxlnnk8BGQ7WMX6w68aw5bGwnu99o0xoyuFxDn8= X-Gm-Gg: ATEYQzztY6aKtGUf42ATfT2EnhfpN0PPzxWOxvMaRvTToDjADoMYY4GuG8jR96XGADD zD2cWdrU6MLAg9OZ/QZ02gv5K9WEUyNfour8uda1jno61WnH/8RATy4+j9QyNVAbMYNwKECZJqK Bta/9clsCA8SehtbO9Sdcxrqx/PIB895eHxaD4eTGFsXgRkr3Zz6rFFRDJXWD0NmOqNVqNl8yFq JXrXng/iOHKR3XNeT8rwBiPc4Xgeq+Ia2jV/dsNtAGoRj8ESp4W0gf3vqxZzPv7318PQHJn9KKR pNZtcz4Ru9iULIdrL2pA6AuRV7OeU7NlJxjuJP9gSsSNlV4/6sdkqOIeoKRjxsZF5lBJY3OI8ek kANrlJ/ADbkkrcoaZveFLIEjeyadHc8BMy2M6Ll+ZKI0R+R8/fL/Td/SMmeTZpULecaZMzuLG9U zv53WJHfMt+OjWAkqrOqBWdmAUdK8QtWwZUXh5yNSOAvH5bkFi+9phNpncLwHJTSoVBOX6p+BLZ Wtg/UVE3Qg3Bl8qIY/50A6ChaM1r+tnq8I= X-Received: by 2002:a05:600c:34c1:b0:47d:6c36:a125 with SMTP id 5b1f17b1804b1-483c993a0e3mr73455575e9.17.1772229705329; Fri, 27 Feb 2026 14:01:45 -0800 (PST) Received: from [192.168.16.154] (host86-188-11-239.range86-188.btcentralplus.com. [86.188.11.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb296bfsm88147225e9.0.2026.02.27.14.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 14:01:44 -0800 (PST) Message-ID: <06249a9b825de30d1fc19fac873840ab3cd7f6aa.camel@linaro.org> Subject: Re: [PATCH v8 03/18] dt-bindings: media: qcom,x1e80100-camss: Add support for combo-mode endpoints From: Christopher Obbard To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Krzysztof Kozlowski Date: Fri, 27 Feb 2026 22:01:43 +0000 In-Reply-To: <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-3-95517393bcb2@linaro.org> References: <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-0-95517393bcb2@linaro.org> <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-3-95517393bcb2@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Bryan, On Wed, 2026-02-25 at 15:11 +0000, Bryan O'Donoghue wrote: > Qualcomm CSI2 PHYs support a mode where two sensors may be attached to th= e > one CSIPHY. >=20 > When we have one endpoint we may have > - DPHY 1, 2 or 4 data lanes + 1 clock lane > - CPHY 3 wire data lane >=20 > When we have two endpoints this indicates the special fixed combo-mode. > - DPHY endpoint0 =3D> 2+1 and endpoint1 =3D> 1+1 data-lane/clock-lane com= bination. >=20 > Signed-off-by: Bryan O'Donoghue Reviewed-by: Christopher Obbard > --- > .../bindings/media/qcom,x1e80100-camss.yaml | 69 ++++++++++++++++= ++++-- > 1 file changed, 65 insertions(+), 4 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.= yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml > index ff14a8248321e..462b1355c9fb7 100644 > --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml > @@ -116,7 +116,8 @@ properties: > $ref: /schemas/graph.yaml#/properties/ports > =20 > description: > - CSI input ports. > + CSI input ports. Supports either standard single sensor mode or > + Qualcomm's combo mode with one sensor in 2x1 + 1x1 data-lane, cloc= k-lane mode. > =20 > patternProperties: > "^port@[0-3]$": > @@ -124,26 +125,86 @@ properties: > unevaluatedProperties: false > =20 > description: > - Input port for receiving CSI data from a CSIPHY. > + Input port for receiving CSI data. > =20 > properties: > - endpoint: > + endpoint@0: > $ref: video-interfaces.yaml# > unevaluatedProperties: false > =20 > + description: > + Endpoint for receiving a single sensor input (or first leg= of combo). > + > properties: > data-lanes: > minItems: 1 > - maxItems: 4 > + maxItems: 4 # Base max allows 4 (for D-PHY) > + > + clock-lanes: > + maxItems: 1 > =20 > bus-type: > enum: > - 1 # MEDIA_BUS_TYPE_CSI2_CPHY > - 4 # MEDIA_BUS_TYPE_CSI2_DPHY > =20 > + endpoint@1: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + description: > + Endpoint for receiving the second leg of a combo sensor in= put. > + > + properties: > + data-lanes: > + maxItems: 1 > + > + clock-lanes: > + maxItems: 1 > + > + bus-type: > + const: 4 # Combo is D-PHY specific > + > required: > - data-lanes > =20 > + allOf: > + # Case 1: Combo Mode (endpoint@1 is present) > + # If endpoint@1 exists, we restrict endpoint@0 to 2 lanes (D-P= HY split) > + - if: > + required: > + - endpoint@1 > + then: > + properties: > + endpoint@0: > + properties: > + data-lanes: > + minItems: 2 > + maxItems: 2 > + bus-type: > + const: 4 > + endpoint@1: > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 1 > + bus-type: > + const: 4 > + > + # Case 2: Single Mode (endpoint@1 is missing) > + # We explicitly allow up to 4 lanes here to cover the D-PHY us= e case. > + - if: > + not: > + required: > + - endpoint@1 > + then: > + properties: > + endpoint@0: > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > required: > - compatible > - reg