From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932781AbbJIHUQ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 9 Oct 2015 03:20:16 -0400
Received: from mail113-251.mail.alibaba.com ([205.204.113.251]:42986 "EHLO
	us-alimail-mta1.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S932759AbbJIHUO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 9 Oct 2015 03:20:14 -0400
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03271;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=2;SR=0;
Reply-To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Nikolay Borisov'" <kernel@kyup.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] ext4: Fix possible deadlock with local interrupts disabled and page-draining IPI
Date: Fri, 09 Oct 2015 15:19:25 +0800
Message-ID: <062501d10262$d40d0a50$7c271ef0$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AdECYnkr9b5PJ20+RGu8Iaf5dUZppA==
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> @@ -109,8 +109,8 @@ static void ext4_finish_bio(struct bio *bio)
>  			if (bio->bi_error)
>  				buffer_io_error(bh);
>  		} while ((bh = bh->b_this_page) != head);
> -		bit_spin_unlock(BH_Uptodate_Lock, &head->b_state);
>  		local_irq_restore(flags);

What if it takes 100ms to unlock after IRQ restored?

> +		bit_spin_unlock(BH_Uptodate_Lock, &head->b_state);
>  		if (!under_io) {
>  #ifdef CONFIG_EXT4_FS_ENCRYPTION
>  			if (ctx)
> --
> 2.5.0