From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA79D32ED2A for ; Tue, 10 Feb 2026 20:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770756893; cv=none; b=VoOwgPm6ZuzW1YPBhioJfVpNkeNFretbqLY1LeGtYEyWvc/pPjBDYrtoxhp7CGZBHEWWFU23LCurO+rRzN/rcONLe72ROf5mKF2RE6NUz/BkRaFNJAxo0/3sNL3/QaKSUQCO6GR+DLwQhsZbI/HQS5NHr40AX3PO6cG0LNUljaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770756893; c=relaxed/simple; bh=XtJKdH9mFRoPZy9JzT3L4Y+tkX+dL1owWZ7qBMPm7ss=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=B4jHgsPLf5sWTgnAzhjg7giSXyUGuxBGd6PQcjHr5dBgNIz/JzuDEf8Wo0mS+rrxjAzEKMdD1qcg6DLpVnIybSK3TVWVeeau2KI81dA/3dWRNWeCEa83KWY2ajeytF3BWE/WXLgQ5A4cPQhPuHI6Vaq6YSlouT72PMh6hFiJF8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YrST5d6O; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YrST5d6O" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-65a1b66d354so125346a12.1 for ; Tue, 10 Feb 2026 12:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770756890; x=1771361690; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding :disposition-notification-to:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=kfTsDpxF/1pt/GYWHrHA8HMvDdV44JWrQ/sRs5nS5WI=; b=YrST5d6OUcKFe2ZehMDoq08DY9wA/SwmkGM5hi58be2DPFLIl+5KgzE2CZFPvGOGxT kkZDlzc0dgcdriAzXSd7o0PqIh0onuvhoS/06jmuoS5YhGU8PcEhG/yKPf8OtCJ0bF6M DsFV4KqEwBV1XSTlfYucfsWT7Vk/D0l8pqQ18J5sBHReaaKovW120lXQVclIYQExYOHQ kUBnKG91iOnRl/MTQHXcYA//o9MtyBTXV6yfOxXs/ruQiKeKRM0k//2jSlbx4Gpm5WBK JIltqtiuLKlycKgBQs3UxI8J0135e5cE++B1h7mV7s0RtOsz6XhsTpsmTfusQTmE/YSm fb6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770756890; x=1771361690; h=mime-version:user-agent:content-transfer-encoding :disposition-notification-to:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kfTsDpxF/1pt/GYWHrHA8HMvDdV44JWrQ/sRs5nS5WI=; b=bHs6UR/FAPnShgJVEJqfzv+GxUlkesBttvphH191LGccIlqDB4aRGJdEMI7jD2jSIk qj1X8LvAF1l/L+IcAwtZa4cdOEipltGcKH6TzrHQ5cHKDEeonSOt5DMkX6m4hssTaxTm XnzuAEVdG6d8276dkXATbldGQqZsOWYYxsifP0XjsiXN60eI4zLbBaOTc6CiWkJRs33t uUu530FwuzIeCcGNpSj+JQym+c08DLNO97HmUE51olP96CgalFx+7i9Z9uoqoorxcbfc NamzGgK9NujQAwbhaS9ixEwveqwIlumcVdP2Cf+nRfOgiDsRpvZpr5Bt8WYVHwjWLCxD 9pwQ== X-Forwarded-Encrypted: i=1; AJvYcCWv7X8BeWY1IpXopQ3Yi6G0WK6R+odyjr84wg7Fqh5qVTL2i5wly2hvjKiu2FnyOzlHG1NlqTmryhKqMH8=@vger.kernel.org X-Gm-Message-State: AOJu0YwuIy40J2huFpHTTKSSkXROa+jZwWgaMVGg15jNsCmcG8/nitDv TyHqlwC2Pk174Zsba4c5+zV/HHpLSFwXij2do+bYgFbFlrzc4/Y9GOvw X-Gm-Gg: AZuq6aIlpPRSh27nzOhoH1/7lCAYJcuNPjIufUTv3JJwy3uwvyCj//UHVFTEJTpJLGq wRuJgTQO1DWRFjShn2yAM5WsKEAbeqVgFV6G5XSmIL9CB5YTFiPAg3NYaVIf8wT7RSdeFfRf/zn LZcutNSd9CGyR5W5HPGd9ZzHYGKAaoX8PIJu7+kfs6FNVz/bD/IIcZGQ2A8zU9lOfmO32ZztPwE EsZY0fVAG3jB79LFgCIKcAEjrSUHXFrz8UhrecN/KbZfYrPICjcdUZ9+gkluq4nzk/XbLshp2y1 igFpKKhjZYE5YebbYm/hIV8fIA0iatYg9bW6GS431bACve5XSqJqMUicpne31zVxat+CzcrjqBy mpgO7XRdqobXDLAISn11BfCqb8DfJftSMr/yylZHOZ36zL/LH2tJf7CJnqh53cEL+o+exJPEWK4 l5NMiJDt0353J0lL1ButKUIfjV1164orVn/rW2+CKyXFOp9STfckNhBQ9xxm5TpXMhu1K1gU0JD o5MLuitokzmvz2vfA2jXg== X-Received: by 2002:a17:907:1c03:b0:b87:6c5c:d3d4 with SMTP id a640c23a62f3a-b8f549a17cbmr130270466b.2.1770756889693; Tue, 10 Feb 2026 12:54:49 -0800 (PST) Received: from [192.168.1.239] (87-205-5-123.static.ip.netia.com.pl. [87.205.5.123]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8f6e71dce1sm93866b.0.2026.02.10.12.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 12:54:49 -0800 (PST) Message-ID: <0627d5bfb4b58e7c767097fd8bf58345eb7196bd.camel@gmail.com> Subject: Re: [PATCH v3 16/19] drm/amd/display: Add parameter to control ALLM behavior From: Tomasz =?UTF-8?Q?Paku=C5=82a?= To: Alex Deucher Cc: Harry Wentland , alexander.deucher@amd.com, sunpeng.li@amd.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, siqueira@igalia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, bernhard.berger@gmail.com, michel.daenzer@mailbox.org, daniel@fooishbar.org, admin@ptr1337.dev Date: Tue, 10 Feb 2026 21:54:46 +0100 In-Reply-To: References: <20260203185626.55428-1-tomasz.pakula.oficjalny@gmail.com> <20260203185626.55428-17-tomasz.pakula.oficjalny@gmail.com> <79264ab170e48e1372b3b847d75f4635dcc57aa6.camel@gmail.com> <1002281ca27d58a47a47fb655a88637e49776706.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-02-10 at 14:17 -0500, Alex Deucher wrote: > On Tue, Feb 10, 2026 at 1:44=E2=80=AFPM Tomasz Paku=C5=82a > wrote: > >=20 > > On Fri, 2026-02-06 at 17:04 -0500, Alex Deucher wrote: > > >=20 > > > Also, maybe a per connector kms property would be preferable. Then > > > you could change it per display. > > >=20 > > > Alex > >=20 > > I've dealt with all Harry's comments but wanted to make sure I > > understand properly. Do you mean, that the two settings should be a > > connector property like VRR_ENABLED? I understand the intent and I thin= k > > in some time, it would be best to have these exposed in compositor > > settings but how would a user control this until then? > >=20 > > Would it suffice to fire IOCTLs from a third-party tool like LACT where > > support for this could be added in a short time? > >=20 > > I made it a module property in the first place, because I thought such > > settings are pretty set-and-forget and module properties are just easy > > to set :) > >=20 > > Still, I think the defaults are sane. If I have to spend some more time > > to get the connector properties working, I could send the patches with > > the module properties ripped out for now. >=20 > My understanding is that these are something the compositor would like > to manage. I'd like to avoid adding module parameters if we can help > it because they usually cause more trouble than they help due to > unforeseen interactions with other features or "conventional wisdom" > blindly followed which leads to a bad user experience. >=20 > Alex Sure! I'll remove the parameters for now and send v4 to get some feedback on the cleanups and then I'll figure out the KMS properties. You're right, leaving that in would surely lead to issues and then people lamenting their removals.. Thanks for all the comments and all your work! Tomasz