From: Andrew Lunn <andrew@lunn.ch>
To: Jianhui Zhao <zhaojh329@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
linux@armlinux.org.uk, netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH] net: phy: Add sysfs attribute for PHY c45 identifiers.
Date: Mon, 12 Jun 2023 16:10:31 +0200 [thread overview]
Message-ID: <062bc2c3-fb3b-43d1-b1d5-4eff754cfe47@lunn.ch> (raw)
In-Reply-To: <20230612140426.1648-1-zhaojh329@gmail.com>
On Mon, Jun 12, 2023 at 10:04:26PM +0800, Jianhui Zhao wrote:
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 17d0d0555a79..81a4bc043ee2 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -541,8 +541,10 @@ static int phy_bus_match(struct device *dev, struct device_driver *drv)
>
> if ((phydrv->phy_id & phydrv->phy_id_mask) ==
> (phydev->c45_ids.device_ids[i] &
> - phydrv->phy_id_mask))
> + phydrv->phy_id_mask)) {
> + phydev->phy_id = phydev->c45_ids.device_ids[i];
> return 1;
> + }
> }
> return 0;
> } else {
>
> How about modifying it like this?
O.K.
Please update the sysfs documentation as well.
Andrew
next prev parent reply other threads:[~2023-06-12 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 15:27 Jianhui Zhao
2023-06-11 15:40 ` Andrew Lunn
2023-06-12 14:04 ` Jianhui Zhao
2023-06-12 14:10 ` Andrew Lunn [this message]
2023-06-12 15:06 ` Russell King (Oracle)
2023-06-12 15:10 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=062bc2c3-fb3b-43d1-b1d5-4eff754cfe47@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhaojh329@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®