From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932657AbbIVK5B (ORCPT ); Tue, 22 Sep 2015 06:57:01 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:45744 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756525AbbIVK47 convert rfc822-to-8bit (ORCPT ); Tue, 22 Sep 2015 06:56:59 -0400 From: Amitkumar Karwar To: Andrzej Hajda , "linux-kernel@vger.kernel.org" CC: Bartlomiej Zolnierkiewicz , Marek Szyprowski , Nishant Sarmukadam , "Kalle Valo" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH 21/38] mwifiex: fix comparison expression Thread-Topic: [PATCH 21/38] mwifiex: fix comparison expression Thread-Index: AQHQ9HKAxIAZ9L1RD0uL7rjciMq05J5IX4lQ Date: Tue, 22 Sep 2015 10:56:54 +0000 Message-ID: <062eac0544f4402f96f63fa104e2afdc@SC-EXCH04.marvell.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-22-git-send-email-a.hajda@samsung.com> In-Reply-To: <1442842450-29769-22-git-send-email-a.hajda@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-09-22_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1509220167 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrzej, > From: Andrzej Hajda [mailto:a.hajda@samsung.com] > Sent: Monday, September 21, 2015 7:04 PM > To: linux-kernel@vger.kernel.org > Cc: Andrzej Hajda; Bartlomiej Zolnierkiewicz; Marek Szyprowski; > Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo; linux- > wireless@vger.kernel.org; netdev@vger.kernel.org > Subject: [PATCH 21/38] mwifiex: fix comparison expression > > To avoid underflows signed variables should be used in expression. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda > --- > drivers/net/wireless/mwifiex/11n_rxreorder.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/mwifiex/11n_rxreorder.c > b/drivers/net/wireless/mwifiex/11n_rxreorder.c > index 2906cd5..b3970a8 100644 > --- a/drivers/net/wireless/mwifiex/11n_rxreorder.c > +++ b/drivers/net/wireless/mwifiex/11n_rxreorder.c > @@ -615,10 +615,10 @@ int mwifiex_11n_rx_reorder_pkt(struct > mwifiex_private *priv, > ((end_win > start_win) && ((seq_num > end_win) || > (seq_num < start_win)))) { > end_win = seq_num; > - if (((seq_num - win_size) + 1) >= 0) > + if (((end_win - win_size) + 1) >= 0) > start_win = (end_win - win_size) + 1; > else > - start_win = (MAX_TID_VALUE - (win_size - seq_num)) + > 1; > + start_win = (MAX_TID_VALUE - (win_size - end_win)) + > 1; > mwifiex_11n_dispatch_pkt_until_start_win(priv, tbl, > start_win); > } > Acked-by: Amitkumar Karwar Regards, Amitkumar