From: Keke Li <keke.li@amlogic.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com,
laurent.pinchart@ideasonboard.com, dan.scally@ideasonboard.com
Subject: Re: [PATCH 3/9] dt-bindings: media: Add amlogic,c3-mipi-adapter.yaml
Date: Wed, 4 Sep 2024 17:07:19 +0800 [thread overview]
Message-ID: <0631d298-2ecc-486a-a9c1-9b7662d6222c@amlogic.com> (raw)
In-Reply-To: <84c4b625-0466-42eb-be11-18b48228cf50@kernel.org>
Hi Krzysztof,
Thanks for your reply.
On 2024/9/3 22:11, Krzysztof Kozlowski wrote:
> [You don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> [ EXTERNAL EMAIL ]
>
> On 03/09/2024 08:57, Keke Li via B4 Relay wrote:
>> From: Keke Li <keke.li@amlogic.com>
>>
>> c3-mipi-adapter is used to organize mipi data and
>> send raw data to ISP module.
>>
>> Signed-off-by: Keke Li <keke.li@amlogic.com>
>> ---
>> .../bindings/media/amlogic,c3-mipi-adapter.yaml | 114 +++++++++++++++++++++
>> 1 file changed, 114 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml
>> new file mode 100644
>> index 000000000000..e1873fe829c7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml
>> @@ -0,0 +1,114 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-adapter.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic C3 MIPI adapter receiver
>> +
>> +maintainers:
>> + - Keke Li <keke.li@amlogic.com>
>> +
>> +description: |-
> Same comment.
OK, get it.
>> + MIPI adapter is used to convert the MIPI CSI-2 data
>> + into an ISP supported data format.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - amlogic,c3-mipi-adapter
>> +
>> + reg:
>> + minItems: 3
> Same comment.
OK, get it.
>> + maxItems: 3
>> +
>> + reg-names:
>> + items:
>> + - const: adap_top
>> + - const: adap_fd
>> + - const: adap_rd
> Same comment.
OK, get it.
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + clocks:
>> + minItems: 2
> Same comment.
OK, get it.
>> +
>> + clock-names:
>> + items:
>> + - const: vapb
>> + - const: adap
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: input port node.
>> +
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: output port node.
>> +
>> + required:
>> + - port@0
>> + - port@1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - power-domains
>> + - clocks
>> + - clock-names
>> + - ports
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h>
>> + #include <dt-bindings/power/amlogic,c3-pwrc.h>
>> +
>> + soc {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + adap: adap@ff010000 {
>> + compatible = "amlogic,c3-mipi-adapter";
>> +
> Same comments.
OK, get it.
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-09-04 9:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 6:57 [PATCH 0/9] Amlogic C3 ISP support Keke Li via B4 Relay
2024-09-03 6:57 ` [PATCH 1/9] dt-bindings: media: Add amlogic,c3-mipi-csi2.yaml Keke Li via B4 Relay
2024-09-03 14:08 ` Krzysztof Kozlowski
2024-09-04 8:15 ` Keke Li
2024-09-03 6:57 ` [PATCH 2/9] media: platform: Add c3 mipi csi2 driver Keke Li via B4 Relay
2024-09-03 14:10 ` Krzysztof Kozlowski
2024-09-04 8:53 ` Keke Li
2024-09-03 6:57 ` [PATCH 3/9] dt-bindings: media: Add amlogic,c3-mipi-adapter.yaml Keke Li via B4 Relay
2024-09-03 14:11 ` Krzysztof Kozlowski
2024-09-04 9:07 ` Keke Li [this message]
2024-09-03 6:57 ` [PATCH 4/9] media: platform: Add c3 mipi adapter driver Keke Li via B4 Relay
2024-09-03 14:12 ` Krzysztof Kozlowski
2024-09-04 9:16 ` Keke Li
2024-09-03 6:57 ` [PATCH 5/9] dt-bindings: media: Add amlogic,c3-isp.yaml Keke Li via B4 Relay
2024-09-03 14:11 ` Krzysztof Kozlowski
2024-09-04 9:21 ` Keke Li
2024-09-03 6:57 ` [PATCH 6/9] media: Add C3ISP_PARAMS and C3ISP_STATS meta formats Keke Li via B4 Relay
2024-09-10 16:59 ` Dan Scally
2024-09-03 6:57 ` [PATCH 7/9] media: platform: Add c3 ISP driver Keke Li via B4 Relay
2024-09-03 6:57 ` [PATCH 8/9] Documentation: media: add documentation file metafmt-c3-isp.rst Keke Li via B4 Relay
2024-09-03 6:57 ` [PATCH 9/9] Documentation: media: add documentation file c3-isp.rst Keke Li via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0631d298-2ecc-486a-a9c1-9b7662d6222c@amlogic.com \
--to=keke.li@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®