mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Kochetkov <al.kochet@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Kevin Hilman <khilman@kernel.org>, Felipe Balbi <balbi@ti.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-omap <linux-omap@vger.kernel.org>,
	linux-i2c@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] i2c: omap: implement workaround for handling invalid BB-bit values
Date: Tue, 25 Nov 2014 03:09:13 +0300	[thread overview]
Message-ID: <06376010-5DED-49AA-9494-A9546567E7CA@gmail.com> (raw)
In-Reply-To: <47749B61-5924-4E56-9931-77B0CFC0AAA0@gmail.com>


24 нояб. 2014 г., в 23:05, Alexander Kochetkov <al.kochet@gmail.com> написал(а):

> Something (u-boot, may be) leave the bus in the wrong state.
> Really strange.

Actually something wrong with i2c-pullups on i2c.1 bus on fault boards.
May be these are boards without pull-ups?
All beagles doesn't have internal pull-ups on i2c.1 since u-boot 2011.x.

Here is the bug in the u-boot related to beagle:
http://git.denx.de/?p=u-boot.git;a=commit;h=04e2a13336f0e507ef416bbede3be92b79c46594

Yes, I made fix, but keep that in mind.

For example one of the boards (omap3-beagle):
http://status.armcloud.us/boot/omap3-beagle/job/next/kernel/next-20141124/defconfig/arm-omap2plus_defconfig/
http://status.armcloud.us/boot/omap3-beagle,legacy/job/next/kernel/next-20141124/defconfig/arm-omap2plus_defconfig/
http://status.armcloud.us/boot/omap3-beagle/job/next/kernel/next-20141124/defconfig/arm-multi_v7_defconfig/

has following warning message in the u-boot log:
> U-Boot 2014.07 (Aug 21 2014 - 11:03:05)
> 
> OMAP3530-GP ES3.0, CPU-OPP2, L3-165MHz, Max CPU Clock 600 MHz
> OMAP3 Beagle board + LPDDR/NAND
> ....
> Beagle Rev C1/C2/C3
> Timed out in wait_for_event: status=1000
> Check if pads/pull-ups of bus 1 are properly configured

Also beagle schematic has following log entry for A3:
4. Added optional pullup resistors on I2C2_SCL and I2C_SDA into the layout.

Is the fault beagle is pre A3 revision?

I can't tell anything about second one board (omap3-overo-tobi), because I could not get it schematic.

And how you have i2c.1 working without pull-ups I don't know.

Alexander.


  reply	other threads:[~2014-11-25  0:09 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 21:28 [RFC 0/4] i2c: omap: patch series related to multimaster mode Alexander Kochetkov
2014-11-20 21:28 ` [PATCH 1/4] i2c: omap: cleanup register definitions Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-20 21:28 ` [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-22 13:23     ` Wolfram Sang
2014-11-22 14:06       ` Alexander Kochetkov
2014-11-22 18:02         ` Wolfram Sang
2014-11-23  4:43           ` Felipe Balbi
2014-11-23 13:18             ` Alexander Kochetkov
2014-11-24 19:08               ` Felipe Balbi
2014-11-24 19:09   ` Felipe Balbi
2014-11-20 21:28 ` [PATCH 3/4] i2c: omap: don't reset controller if Arbitration Lost detected Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-21 18:11   ` Wolfram Sang
2014-11-21 22:51   ` [PATCH v2 " Alexander Kochetkov
2014-11-22  1:07     ` Felipe Balbi
2014-11-20 21:28 ` [PATCH 4/4] i2c: omap: add notes related to i2c multimaster mode Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-22 19:47 ` [PATCH v3 0/4] i2c: omap: patch series related to " Alexander Kochetkov
2014-11-22 19:47   ` [PATCH v3 1/4] i2c: omap: cleanup register definitions Alexander Kochetkov
2014-11-22 19:47   ` [PATCH v3 2/4] i2c: omap: implement workaround for handling invalid BB-bit values Alexander Kochetkov
2014-11-24 19:08     ` Kevin Hilman
2014-11-24 19:10       ` Felipe Balbi
2014-11-24 19:13         ` Wolfram Sang
2014-11-24 19:25           ` Tony Lindgren
2014-11-24 19:39       ` Alexander Kochetkov
2014-11-24 19:47         ` Tony Lindgren
2014-11-24 20:05           ` Alexander Kochetkov
2014-11-25  0:09             ` Alexander Kochetkov [this message]
2014-11-25 15:41               ` Tony Lindgren
2014-11-24 21:08           ` Alexander Kochetkov
2014-11-26 22:30           ` Alexander Kochetkov
2014-11-24 20:33     ` [PATCH] omap: i2c: don't check bus state IP rev3.3 and earlier Alexander Kochetkov
2014-11-24 21:08       ` Tony Lindgren
2014-11-24 22:20         ` [PATCH v2] " Alexander Kochetkov
2014-11-25 14:19           ` Wolfram Sang
2014-11-25 14:38             ` Alexander Kochetkov
2014-11-25 19:13               ` Kevin Hilman
2014-11-26 19:26                 ` Alexander Kochetkov
2014-11-26 21:33                   ` Kevin Hilman
2014-11-25 19:12           ` Kevin Hilman
2014-11-26 19:05     ` [RFC] i2c: omap: TEST: do IP reset during probe Alexander Kochetkov
2014-11-26 21:25       ` Kevin Hilman
2014-11-28 22:13         ` Tony Lindgren
2014-11-28 23:25           ` Alexander Kochetkov
2014-11-29 22:06             ` Tony Lindgren
2014-11-29  2:14           ` Alexander Kochetkov
2014-11-22 19:47   ` [PATCH v3 3/4] i2c: omap: don't reset controller if Arbitration Lost detected Alexander Kochetkov
2014-11-22 19:47   ` [PATCH v3 4/4] i2c: omap: add notes related to i2c multimaster mode Alexander Kochetkov
2014-11-22 21:08   ` [PATCH v3 0/4] i2c: omap: patch series related to " Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06376010-5DED-49AA-9494-A9546567E7CA@gmail.com \
    --to=al.kochet@gmail.com \
    --cc=balbi@ti.com \
    --cc=khilman@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®