From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C478F30DD08 for ; Wed, 18 Feb 2026 11:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771414763; cv=none; b=Uo2z/6G7NaohQMHrXWn8rM7eb+xfssXtZfcRuroz0lKRaMRvXiHaUsyFhN3/H8XMeeClvu/0k2/kEQRaxaR4lfIIPKcx4k+D84V0roIrufiEVyW2jh1tjgYwRjNPn3t3LZD+SZOtZEWSqoffU2SKxLCTqi8LRByh9SSspiV0iuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771414763; c=relaxed/simple; bh=FMdxVUC0R0jadThg3kkIYRMnfauWR9cEQM0ddy7MYIk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KhIo/GTwj1GyZvKlYjSre4F0qNI+I3MLTPrKY3e3L8fPwuib66/b4/c8wYzVmL626+xHcR3cs0+dv13zS3Hju21zIBSGfB2KIl87XFD44ELn0Tm4pYd9XkM1/NW1ZQAoOyWPaGExu1DdRmpUuaywDCxGgGBWBjab6G28l63dLUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gIpcpKtR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TOMHMakg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gIpcpKtR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TOMHMakg" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61I5JwOu421076 for ; Wed, 18 Feb 2026 11:39:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ppdqtJT3CiJXkezhUY3eB7UumNbDs0BXpqi0rJyn9YM=; b=gIpcpKtRlocQGhfB 8cNWhZ3i6Vdemt5LbFRVGiyKuvWz5ZuNlouqqozJK1nK8iIBB/Zm1Wu5FVi4vRSy Kw9cjBtGzni8YLJ09qBNFqnpVgxkbSf7uSeE5XTexSNoNYgfuQ7t2r0tjl1XzeIM /rA85ITlK6JZgTmQOzVy1KX1P+/kKrcHFxlqnGbxQbiSM4TE4E4szS/rDrEdqWiH w6c7ODeXrx+kkqlIkmPDDQwbdcUsV0BiUyZ+A6VSkR9SYRF+vOvc9CveBFHpkCwk oJABwdcYkZ2OepJh043liyOT6sv0x8Q5GXGOIme4+9bVFKVJdXyiPcopE08ngVkW Q6qo8A== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cd76e0vy9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Feb 2026 11:39:21 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8243a06b397so2666673b3a.0 for ; Wed, 18 Feb 2026 03:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771414761; x=1772019561; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ppdqtJT3CiJXkezhUY3eB7UumNbDs0BXpqi0rJyn9YM=; b=TOMHMakg7i+rPwaVOltwJr+Sarhv1JGRudROURfoXR8sJqlXni/BqaoMrVEx0zP/Me 82xE/znzzqpvwQQL3SLiT4inPkE+uq+hvy0wV5E/6oVn0jGeRKY1iOMpXJoI8mCrfOT0 pDcDfMIXlxYiY0NUp5X0FyTpMYRMtdhQF5IpDcZo92HIVE5O7fr5vC/VKGczAVOrBKxl aRqbSziNsMxI6gSBOZnUg+MQMiuX8ZO76FVkrrckzvqcdrg2PbTj0wyNzh5MU3BhUqwk Wo9txClsluxiog1I76OfjCDzIWnB/4havpWy0azBO9UFOBkzB1FGsup8e8oHXndQDQzy 0K/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771414761; x=1772019561; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ppdqtJT3CiJXkezhUY3eB7UumNbDs0BXpqi0rJyn9YM=; b=Q8ixeMuO9kw+HisSWCQUKhKibse9e6VNYjpRe1NphP4v/ro0uP6c0lE37KdS4ESRQJ 5/g4kjqBRT/GHNMVs7LLsNFUDQat79uEwnoj9t6GOvPpK5iIHvV2ZfNBnDAsBlmwBFlG Pl4Y14Bl/0iBfq6hWHLQBFzjYMAWha35pRMV4jxVSHh2EPEN+rhMUiTkjkyht55403s4 7iNeyJ/9Q/s6xqk9UurqIYys3BDa5fjvy/r4tl239e14gYQd7QJ3DCo5hzv/LpK4SrJp v1t0fs+NPok8MzmefiV4d46m0xjhMpxG/a/R1Awn+IS6pz920KEqJ7OGQC8US0TJ+6Rr bZiA== X-Forwarded-Encrypted: i=1; AJvYcCUdZAgJspK12GuQOzpxbdT/q5co8kiLuTtmocqghnkAUioJvEqXKEFLT7xgkUga7PKwJD9QirrLRfY+fek=@vger.kernel.org X-Gm-Message-State: AOJu0YykmWhgP5QL4K+vcckkydW9SFQM+SGnFAUQuhoe246jlXIH3JEd O/hI2pWcrMOg9X5a+xFxpB1kkAs8AMKOIiFiCe26AdJzjH7HVnPZEgxlUNdCBBpr7ct4Q9eZrd2 bmtxvGtdDb+S9Uf+HuJIS3R1RStpugD74rn6bjuxQ62Bb08PcFsR9NUlwHdmsKJGO3UQ= X-Gm-Gg: AZuq6aItJZNbJ0zG1uZf+JHJXIBzGNDpQzCZTM9u0iJoFAYtODTqXzjTHWGlmB6ydaD QYIox3nzhDAeei2NU5qQmDx/I1EqkYRo9TQFWt49pfFuTOzsYiORUwt7RVk2A8LCC05QzaE8zb4 KmKhRLzDTQ8I5KWpayi2ZTzesj00bG0T6bQL9FrnHdP9SArfSSNHSaaAIzYFpean7qx9mWJcr/f K/HOT3nb4huCISWjx/0CRA3ToDbJqw4+dfP4SpEJrNN/8kCJN+5D6JNXAlk91owr2rxmjBUYfjE SfgAfMDWU2AkARhEcYcc8NASEB/CUkxglAcBgMu7ix8Dys2KJbDzGkPYgXQNWwnJBwNhpB/PVI5 mTVG+pL9jZPpSCiTIRfo5b3cNtxarrt8WvuYKp1DB4g4YvcKQ X-Received: by 2002:a05:6a00:368f:b0:823:7c4:d81d with SMTP id d2e1a72fcca58-825274749bfmr1844233b3a.6.1771414761146; Wed, 18 Feb 2026 03:39:21 -0800 (PST) X-Received: by 2002:a05:6a00:368f:b0:823:7c4:d81d with SMTP id d2e1a72fcca58-825274749bfmr1844197b3a.6.1771414760601; Wed, 18 Feb 2026 03:39:20 -0800 (PST) Received: from [10.218.16.122] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6bb25e9sm16895776b3a.56.2026.02.18.03.39.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 03:39:20 -0800 (PST) Message-ID: <0637e27c-cadd-45e7-9c43-cc510c431f2d@oss.qualcomm.com> Date: Wed, 18 Feb 2026 17:09:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] Bluetooth: qca: add QCC2072 support To: Dmitry Baryshkov Cc: Krzysztof Kozlowski , Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Balakrishna Godavarthi , Rocky Liao , quic_mohamull@quicinc.com, quic_hbandi@quicinc.com, janaki.thota@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260217054731.3058567-1-vivek.sahu@oss.qualcomm.com> <20260217054731.3058567-3-vivek.sahu@oss.qualcomm.com> <19d3cced-f630-4a6b-853e-3798487fd769@oss.qualcomm.com> <20260217-mighty-organic-oxpecker-2ed848@quoll> <3v3iz5cxsbaoevcfkk7itutdepfuagxoemixgfhewdevmju2ut@rcg3zuyg4gzn> Content-Language: en-US From: Vivek Sahu In-Reply-To: <3v3iz5cxsbaoevcfkk7itutdepfuagxoemixgfhewdevmju2ut@rcg3zuyg4gzn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=OKsqHCaB c=1 sm=1 tr=0 ts=6995a4e9 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=ZkFF6JlifP4NxvfhLXQA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE4MDEwMyBTYWx0ZWRfXwZt6EZrvInLx nFNv9R5WGpa1ozb1nZqpo9o07mWzXq9/AAHW4l1p4lAzlgfIPBwGwaFmIclGYJP9vPe8qHO8qBI +0+zFDYdmfOwaTks8pZCR0Jq819CjW01daKj5579YPzTUYVVQBLu/j3QqgyHAHB7FvXpDS33Ufd WPMXSUWl+mm+isZynABsroNkoGn05hLdMSsTqbRb8TVDUKQugfCjq58/mlgaqDRpZNHWzpzJyGy 9GAJfPpZ/O+ceefB/OMXWLZ8jgGeLkt39EY8b5sUIfe7hXkCYrvQxuG0nIfWGHfld44JfVpfknI L26FiC38h4BItYWcUlI+62KlzNU3vBz6ca7yz9WS1qkdgkYkdhfDP9A1PyRU4hnMdh0hh5GSQHB buJ4WIyJXqfXC6ObecPQrUQ6bQI9fZuNqwZ9bXj7Edr4wNdzC9w6SRU9cXQE4qjGnTN92RL9+Tw 6y89YdTL/YTylUf7u+Q== X-Proofpoint-GUID: h4o-kPau2_buB8oLrXaVRQqMlCaQ9-1h X-Proofpoint-ORIG-GUID: h4o-kPau2_buB8oLrXaVRQqMlCaQ9-1h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602180103 On 2/17/2026 6:31 PM, Dmitry Baryshkov wrote: > On Tue, Feb 17, 2026 at 06:21:19PM +0530, Vivek Sahu wrote: >> >> >> On 2/17/2026 1:23 PM, Krzysztof Kozlowski wrote: >>> On Tue, Feb 17, 2026 at 01:17:29PM +0530, Vivek Sahu wrote: >>>>>> + case QCA_QCC2072: >>>>>> + snprintf(config.fwname, sizeof(config.fwname), >>>>>> + "qca/ornnv%02x.bin", rom_ver); >>>>>> + break; >>>>>> case QCA_WCN3950: >>>>>> if (le32_to_cpu(ver.soc_id) == QCA_WCN3950_SOC_ID_T) >>>>>> variant = "t"; >>>>>> diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h >>>>>> index 8f3c1b1c77b3..a175ac31e7b2 100644 >>>>>> --- a/drivers/bluetooth/btqca.h >>>>>> +++ b/drivers/bluetooth/btqca.h >>>>>> @@ -158,6 +158,7 @@ enum qca_btsoc_type { >>>>>> QCA_WCN6750, >>>>>> QCA_WCN6855, >>>>>> QCA_WCN7850, >>>>>> + QCA_QCC2072, >>>>> >>>>> Why not keep it sorted? >>>>> >>>> As mentioned in the cover letter "qca_btsoc_type" enum in >>>> drivers/bluetooth/btqca.h contains all the soc type which need to be enabled >>>> for BT enablement on the target device. There are few places where logic of >>>> framing packets transferring between SoC and Host depends on the which >>>> generation of the chip it is, refer api "qca_read_soc_version". So It is not >>>> sorted in btqca.h file. >>> >>> Neither in previous patch comments nor here you respond to actual >>> comment. You just write something completely irrelevant. >>> >>> I don't think any of this should be considered if you are not >>> responding to actual comments. >>> >>> >>> Best regards, >>> Krzysztof >>> >> There is high impact on the existing design if i make this enum sorted. We > > What kind of "high impact"? > We identified a better way of handling it. I'll move it to the correct place. >> are considering your comments regarding sorting for next commit not for this >> commit. Can we have approval for this commit if all other changes looks >> fine. > > > No. >