From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8E8C04AB5 for ; Thu, 6 Jun 2019 07:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D5CA207E0 for ; Thu, 6 Jun 2019 07:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbfFFHFa (ORCPT ); Thu, 6 Jun 2019 03:05:30 -0400 Received: from gate.crashing.org ([63.228.1.57]:35610 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbfFFHFa (ORCPT ); Thu, 6 Jun 2019 03:05:30 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x5674w8h020392; Thu, 6 Jun 2019 02:04:59 -0500 Message-ID: <06384baa09e0f24e0c33f560f461233ef4405799.camel@kernel.crashing.org> Subject: Re: [PATCH 2/3] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver From: Benjamin Herrenschmidt To: Greg KH Cc: Talel Shenhar , nicolas.ferre@microchip.com, jason@lakedaemon.net, marc.zyngier@arm.com, mark.rutland@arm.com, mchehab+samsung@kernel.org, robh+dt@kernel.org, davem@davemloft.net, shawn.lin@rock-chips.com, tglx@linutronix.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, jonnyc@amazon.com, hhhawa@amazon.com, ronenk@amazon.com, hanochu@amazon.com, barakw@amazon.com Date: Thu, 06 Jun 2019 17:04:57 +1000 In-Reply-To: <61fe2a4c80e654476a68929da9dcc18df8bc2639.camel@kernel.crashing.org> References: <1559717653-11258-1-git-send-email-talel@amazon.com> <1559717653-11258-3-git-send-email-talel@amazon.com> <20190605075927.GA9693@kroah.com> <20190606063741.GA23305@kroah.com> <61fe2a4c80e654476a68929da9dcc18df8bc2639.camel@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-06-06 at 16:47 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2019-06-06 at 08:37 +0200, Greg KH wrote: > > On Thu, Jun 06, 2019 at 07:55:43AM +1000, Benjamin Herrenschmidt wrote: > > > On Wed, 2019-06-05 at 09:59 +0200, Greg KH wrote: > > > > > > > > > +struct irq_domain *al_fic_wire_get_domain(struct al_fic *fic); > > > > > + > > > > > +struct al_fic *al_fic_wire_init(struct device_node *node, > > > > > + void __iomem *base, > > > > > + const char *name, > > > > > + unsigned int parent_irq); > > > > > +int al_fic_cleanup(struct al_fic *fic); > > > > > > > > Who is using these new functions? We don't add new apis that no one > > > > uses :( > > > > > > They will be used by subsequent driver submissions but those aren't > > > quite ready yet, so we can hold onto patch 3 for now until they are. > > > > Patch 2 also should have these removed :) > > That's a mistake, that export should have been in patch3. Talel, pls > fix that in your next spin. Actually that's already fixed in v2 of the series. The API have been removed for now. Cheers, Ben.