mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: "'Joe Perches'" <joe@perches.com>,
	Thomas Winischhofer <thomas@winischhofer.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb <linux-usb@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: RE: sisusb: Use static const, fix typo
Date: Mon, 24 Feb 2014 10:26:53 +0000	[thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6C9771@AcuExch.aculab.com> (raw)
In-Reply-To: <1393034412.3627.11.camel@joe-AO722>

From: Joe Perches
> Reduce text a bit by using static const.

If you want to save a few bytes remove the pointers.
(and the fixed RAM text to get below 7 chars).
eg:

> -	const char *ramtypetext2[] = {	"SDR SDRAM", "SDR SGRAM",
> -					"DDR SDRAM", "DDR SGRAM" };

	static const char ramtypetext2[8][] = {
		"SDR SD", "SDR SG", "DDR SD", "DDR SG"

...
> -	dev_info(&sisusb->sisusb_dev->dev, "%dMB %s %s, bus width %d\n", (sisusb->vramsize >> 20),
> ramtypetext1,
> -			ramtypetext2[ramtype], bw);

	dev_info(&sisusb->sisusb_dev->dev, "%dMB %s %sRAM, bus width %d\n",
		 sisusb->vramsize >> 20, ramtypetext1, ramtypetext2[ramtype],
		 bw);

	David




  reply	other threads:[~2014-02-24 10:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-22  2:00 Joe Perches
2014-02-24 10:26 ` David Laight [this message]
2014-02-24 18:01   ` Joe Perches
2014-02-25  9:09     ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=063D6719AE5E284EB5DD2968C1650D6D0F6C9771@AcuExch.aculab.com \
    --to=david.laight@aculab.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=thomas@winischhofer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®