From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932215AbaCDMML (ORCPT ); Tue, 4 Mar 2014 07:12:11 -0500 Received: from mx0.aculab.com ([213.249.233.131]:45820 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932066AbaCDMMJ convert rfc822-to-8bit (ORCPT ); Tue, 4 Mar 2014 07:12:09 -0500 From: David Laight To: "'Hayes Wang'" , "netdev@vger.kernel.org" CC: "nic_swsd@realtek.com" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH net-next 08/12] r8152: support TSO Thread-Topic: [PATCH net-next 08/12] r8152: support TSO Thread-Index: AQHPN6ICLRomJZLUN0ak16x5aFoKeJrQ1RDA Date: Tue, 4 Mar 2014 12:11:44 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6CFFE0@AcuExch.aculab.com> References: <1393934464-23675-1-git-send-email-hayeswang@realtek.com> <1393934464-23675-9-git-send-email-hayeswang@realtek.com> In-Reply-To: <1393934464-23675-9-git-send-email-hayeswang@realtek.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang > Support scatter gather and TSO. > > Adjust the tx checksum function and set the max gso size to fix the > size of the tx aggregation buffer. There is little point supporting TSO unless the usb host controller supports arbitrary aligned scatter-gather. All you do is require that a large skb be allocated (that may well fail), and add it another data copy. The xhci controller is almost capable of arbitrary scatter-gather, but it is currently disabled because the data must be aligned at the end of the transfer ring (the hardware designers have made it almost impossible to write efficient software). Note that the various xhci controllers behave subtly differently. David