From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753547AbaCZJnv (ORCPT ); Wed, 26 Mar 2014 05:43:51 -0400 Received: from mx0.aculab.com ([213.249.233.131]:39251 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750956AbaCZJnu (ORCPT ); Wed, 26 Mar 2014 05:43:50 -0400 From: David Laight To: "'Cody P Schafer'" , Anton Blanchard CC: Peter Zijlstra , LKML , Michael Ellerman , Ingo Molnar , Paul Mackerras , "Arnaldo Carvalho de Melo" , "scottwood@freescale.com" , Linux PPC Subject: RE: [PATCH v4 09/11] powerpc/perf: add support for the hv 24x7 interface Thread-Topic: [PATCH v4 09/11] powerpc/perf: add support for the hv 24x7 interface Thread-Index: AQHPSFiWjqiJ3SqT8EmaHwjaR2yLrprzHYVg Date: Wed, 26 Mar 2014 09:43:02 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6E93BC@AcuExch.aculab.com> References: <1394064082-6242-1-git-send-email-cody@linux.vnet.ibm.com> <1394064082-6242-10-git-send-email-cody@linux.vnet.ibm.com> <20140325214356.4a2f7d95@kryten> <5331CBB0.8080500@linux.vnet.ibm.com> In-Reply-To: <5331CBB0.8080500@linux.vnet.ibm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s2Q9hx5N028231 From: Cody P Schafer > On 03/25/2014 03:43 AM, Anton Blanchard wrote: > > > > Hi Cody, > > > > hv-24x7: could not obtain capabilities, error 0x > fffffffffffffffe, not enabling > > hv-gpci: could not obtain capabilities, error 0x > fffffffffffffffe, not enabling > > > >> + pr_info("could not obtain capabilities, error 0x%80lx, not enabling\n", > > > > That's a lot of padding :) > > > > I think this should also be a pr_debug, considering this is not relevant > > to most ppc64 boxes. > > Yep, s/info/debug/ makes sense. The format should have been "%08lx" not > "%80lx", not sure when I screwed that up. Using "%#x" is an alternative - unless you really need fixed width. However in this case "%ld" might be more appropriate! If the value is a -ve errno one, maybe even "errno %d" and negate the value. David {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I