From: David Laight <David.Laight@ACULAB.COM>
To: "'Ricardo Ribalda Delgado'" <ricardo.ribalda@gmail.com>,
"balbi@ti.com" <balbi@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"joe@perches.com" <joe@perches.com>,
"auttamchandani@logicube.com" <auttamchandani@logicube.com>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Subject: RE: [PATCH 3/5] usb: gadget: net2280: Use BIT() macro
Date: Mon, 19 May 2014 10:18:25 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1724900B@AcuExch.aculab.com> (raw)
In-Reply-To: <1400494205-26566-3-git-send-email-ricardo.ribalda@gmail.com>
From: Ricardo Ribalda Delgado
> Improves readability of the code
Personally I don't find macros like BIT() improve the readability at all.
What next? Maybe:
#define ADD(a, b) ((a) + (b))
David
next prev parent reply other threads:[~2014-05-19 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 10:10 [PATCH 1/5 v5] usb: gadget: net2280: Add support for PLX USB338X Ricardo Ribalda Delgado
2014-05-19 10:10 ` [PATCH 2/5] usb: gadget: net2280: Dont use magic numbers Ricardo Ribalda Delgado
2014-05-19 10:10 ` [PATCH 3/5] usb: gadget: net2280: Use BIT() macro Ricardo Ribalda Delgado
2014-05-19 10:18 ` David Laight [this message]
2014-05-19 10:24 ` Ricardo Ribalda Delgado
2014-05-19 10:10 ` [PATCH 4/5] usb: gadget: net2280: Use true/false instead of 1/0 Ricardo Ribalda Delgado
2014-05-19 10:10 ` [PATCH 5/5] usb: gadget: net2280: Use module_pci_driver macro Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6D1724900B@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=auttamchandani@logicube.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®