From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753170AbaHKIyY (ORCPT ); Mon, 11 Aug 2014 04:54:24 -0400 Received: from mx0.aculab.com ([213.249.233.131]:52439 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752580AbaHKIyU (ORCPT ); Mon, 11 Aug 2014 04:54:20 -0400 From: David Laight To: "'Mathias Nyman'" , Julius Werner , Paul Zimmerman CC: Maciej Puzio , Mathias Nyman , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] usb: xhci: Fix Set TR Dequeue Pointer cycle state for quirky xHCs Thread-Topic: [PATCH] usb: xhci: Fix Set TR Dequeue Pointer cycle state for quirky xHCs Thread-Index: AQHPp0ZkVkDSwZ/t0EWXkV2roFJKzZvLNFSA Date: Mon, 11 Aug 2014 08:52:34 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1747473D@AcuExch.aculab.com> References: <063D6719AE5E284EB5DD2968C1650D6D1726E25E@AcuExch.aculab.com> <1404846104-4959-1-git-send-email-jwerner@chromium.org> <53D11293.7050606@linux.intel.com> In-Reply-To: <53D11293.7050606@linux.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s7B8sS2e006132 > It's starting to get a bit too complicated. > xhci find_new_dequeue_state() now has four places where it can toggle the cycle bit > in addition to the cycle toggle in find_trb_seg(). > > In the end we really just want to do it max once. > > I'll see if I can simplify the whole cycle bit code somehow. Have a look at the patches I submitted last year. I remember simplifying a lot of that code. David {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I