From: David Laight <David.Laight@ACULAB.COM>
To: "'Chunhao Lin'" <hau@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "nic_swsd@realtek.com" <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next 07/11] r8169:update rtl8168f pcie ephy parameter
Date: Wed, 7 Jan 2015 16:45:58 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CAC2C99@AcuExch.aculab.com> (raw)
In-Reply-To: <1420648826-12972-8-git-send-email-hau@realtek.com>
From: Chunhao Lin
> rtl8168f may return to PCIe L0 from PCIe L0s low power mode too slow.
> The following ephy parameters are for this issue.
> { 0x00, 0x0000, 0x0008 }
> { 0x0c, 0x3df0, 0x0200 }
>
> Signed-off-by: Chunhao Lin <hau@realtek.com>
> ---
> drivers/net/ethernet/realtek/r8169.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 1874583..bafa132 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -5852,7 +5852,9 @@ static void rtl_hw_start_8168f_1(struct rtl8169_private *tp)
> { 0x06, 0x00c0, 0x0020 },
> { 0x08, 0x0001, 0x0002 },
> { 0x09, 0x0000, 0x0080 },
> - { 0x19, 0x0000, 0x0224 }
> + { 0x19, 0x0000, 0x0224 },
> + { 0x00, 0x0000, 0x0008 },
> + { 0x0c, 0x3df0, 0x0200 }
I can't help feeling these lines all require short comments.
David
next prev parent reply other threads:[~2015-01-07 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 16:40 [PATCH net-next 00/11]r8169:update hardware parameter Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 01/11] r8169:change rtl8168dp jumbo frame patch Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 02/11] r8169:update rtl8168e and rtl8168evl " Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 03/11] r8169:change the way of setting rtl8168dp ephy parameters Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 04/11] r8169:update rtl8168dp pcie ephy parameter Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 05/11] r8169:remove function rtl_hw_start_8168dp Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 06/11] r8169:update rtl8168evl pcie ephy parameter Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 07/11] r8169:update rtl8168f " Chunhao Lin
2015-01-07 16:45 ` David Laight [this message]
2015-01-09 4:08 ` David Miller
2015-01-09 5:18 ` Hau
2015-01-07 16:40 ` [PATCH net-next 08/11] r8169:update rtl8411 " Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 09/11] r8169:update rtl8105e " Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 10/11] r8169:update rtl8402 " Chunhao Lin
2015-01-07 16:40 ` [PATCH net-next 11/11] r8169:update rtl8168f rev.b " Chunhao Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6D1CAC2C99@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=hau@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®