From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754621AbbDQPP1 (ORCPT ); Fri, 17 Apr 2015 11:15:27 -0400 Received: from smtp-out6.electric.net ([192.162.217.186]:59837 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754563AbbDQPP0 (ORCPT ); Fri, 17 Apr 2015 11:15:26 -0400 From: David Laight To: "'Christophe Leroy'" , Kim Phillips , Herbert Xu , David S Miller CC: "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" Subject: RE: [PATCH v3 03/17] crypto: talitos - talitos_ptr renamed ptr for more lisibility Thread-Topic: [PATCH v3 03/17] crypto: talitos - talitos_ptr renamed ptr for more lisibility Thread-Index: AQHQeRq1klMt9Zfu6U+R2vsKcAUTLp1RT5eA Date: Fri, 17 Apr 2015 15:14:18 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB21235@AcuExch.aculab.com> References: <20150417142356.797BC1A242C@localhost.localdomain> In-Reply-To: <20150417142356.797BC1A242C@localhost.localdomain> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t3HFFWZf032175 From: Christophe Leroy > Linux CodyingStyle recommends to use short variables for local > variables. ptr is just good enough for those 3 lines functions. > It helps keep single lines shorter than 80 characters. ... > -static void to_talitos_ptr(struct talitos_ptr *talitos_ptr, dma_addr_t dma_addr) > +static void to_talitos_ptr(struct talitos_ptr *ptr, dma_addr_t dma_addr) > { > - talitos_ptr->ptr = cpu_to_be32(lower_32_bits(dma_addr)); > - talitos_ptr->eptr = upper_32_bits(dma_addr); > + ptr->ptr = cpu_to_be32(lower_32_bits(dma_addr)); > + ptr->eptr = upper_32_bits(dma_addr); > } ... Maybe, but 'ptr' isn't a good choice. David {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I