From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbbIPM4z (ORCPT ); Wed, 16 Sep 2015 08:56:55 -0400 Received: from smtp-out6.electric.net ([192.162.217.195]:64377 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752362AbbIPM4x (ORCPT ); Wed, 16 Sep 2015 08:56:53 -0400 From: David Laight To: "'Austin S Hemmelgarn'" , Steve Calfee , Eric Curtin CC: Valentina Manea , "shuah.kh@samsung.com" , USB list , "Kernel development list" Subject: RE: First kernel patch (optimization) Thread-Topic: First kernel patch (optimization) Thread-Index: AQHQ8HU1DYbiR3Tqn0q6zOVXzhX/z54/G9Mw Date: Wed, 16 Sep 2015 12:56:19 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB97D13@AcuExch.aculab.com> References: <1442346808-3784-1-git-send-email-ericcurtin17@gmail.com> <55F95671.6060405@gmail.com> In-Reply-To: <55F95671.6060405@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8GCv1e5001951 From: Austin S Hemmelgarn > Sent: 16 September 2015 12:46 > On 2015-09-15 20:09, Steve Calfee wrote: > > On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: > >> Signed-off-by: Eric Curtin > >> > >> diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c > >> index 05c6d15..9db9d21 100644 > >> --- a/tools/usb/usbip/src/usbip_detach.c > >> +++ b/tools/usb/usbip/src/usbip_detach.c > >> @@ -47,7 +47,9 @@ static int detach_port(char *port) > >> uint8_t portnum; > >> char path[PATH_MAX+1]; > >> > >> - > >> + unsigned int port_len = strlen(port); > >> + > >> + for (unsigned int i = 0; i < port_len; i++) > >> if (!isdigit(port[i])) { > >> err("invalid port %s", port); > >> return -1; > >> > >> -- > > > > Hi Eric, > > > > This is fine, but what kind of wimpy compiler optimizer will not move > > the constant initializer out of the loop? I bet if you compare binary > > sizes/code it will be exactly the same, and you added some characters > > of code. Reorganizing code for readability is fine, but for compiler > > (in)efficiency seems like a bad idea. > While I agree with your argument, I would like to point out that it is a > well established fact that GCC's optimizers are kind of brain-dead at > times and need their hands held. > > I'd be willing to bet that the code will be marginally larger (because > of adding another variable), but might run slightly faster too (because > in my experience, GCC doesn't always catch things like this), and should > compile a little faster (because the optimizers don't have to do as much > work). The compiler probably can't optimise the strlen(). If isdigit() is a real function (the locale specific one probably is) then the compile cannot assume that port[n] isn't changed by the call to isdigit. A simpler change would be: for (unsigned int i = 0; port[i] != 0; i++) Much better would be to use strtoul() instead of atoi(). David ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±þG«�éÿŠ{ayºʇڙë,j­¢f£¢·hš�ï�êÿ‘êçz_è®(­éšŽŠÝ¢j"�ú¶m§ÿÿ¾«þG«�éÿ¢¸?™¨è­Ú&£ø§~�á¶iO•æ¬z·švØ^¶m§ÿÿà ÿ¶ìÿ¢¸?–I¥