From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752341AbbKJJmb (ORCPT ); Tue, 10 Nov 2015 04:42:31 -0500 Received: from smtp-out6.electric.net ([192.162.217.193]:59806 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbbKJJm1 (ORCPT ); Tue, 10 Nov 2015 04:42:27 -0500 From: David Laight To: "'Michael Ellerman'" , "robh+dt@kernel.org" CC: "devicetree@vger.kernel.org" , "frowand.list@gmail.com" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@ozlabs.org" , "grant.likely@linaro.org" , "mitchelh@codeaurora.org" Subject: RE: [PATCH] of: Print rather than WARN'ing when overlap check fails Thread-Topic: [PATCH] of: Print rather than WARN'ing when overlap check fails Thread-Index: AQHRG3XdM0Pq11rdrkGgEV3NhD+/fZ6VAJsA Date: Tue, 10 Nov 2015 09:41:18 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CBCEE2E@AcuExch.aculab.com> References: <1447132113-31434-1-git-send-email-mpe@ellerman.id.au> In-Reply-To: <1447132113-31434-1-git-send-email-mpe@ellerman.id.au> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAA9gZi8015401 From: Michael Ellerman > Sent: 10 November 2015 05:09 > __rmem_check_for_overlap() is called very early in boot, and on some > powerpc systems it's not safe to call WARN that early in boot. > > If the overlap check fails the system will oops instead of printing a > warning. Furthermore because it's so early in boot the console is not up > and the user doesn't see the oops, they just get a dead system. Wouldn't it be better to add the required checks to WARN()? That would stop the same problem happening elsewhere. David {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I