From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757960AbcBCQyz (ORCPT ); Wed, 3 Feb 2016 11:54:55 -0500 Received: from smtp-out6.electric.net ([192.162.217.190]:54292 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754840AbcBCQyy convert rfc822-to-8bit (ORCPT ); Wed, 3 Feb 2016 11:54:54 -0500 From: David Laight To: "'Paul Burton'" , "linux-mips@linux-mips.org" , Ralf Baechle CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 6/6] net: pch_gbe: Allow longer for resets Thread-Topic: [PATCH v2 6/6] net: pch_gbe: Allow longer for resets Thread-Index: AQHRXnq3fgQTopO/nkaWnymXFPZpDp8aiNpg Date: Wed, 3 Feb 2016 16:51:34 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CCD57CD@AcuExch.aculab.com> References: <1454500964-6256-1-git-send-email-paul.burton@imgtec.com> <1454500964-6256-7-git-send-email-paul.burton@imgtec.com> In-Reply-To: <1454500964-6256-7-git-send-email-paul.burton@imgtec.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Burton > Sent: 03 February 2016 12:03 > Resets of the EG20T MAC on the MIPS Boston development board take longer > than the 1000 loops that pch_gbe_wait_clr_bit was performing. Bump up > the number of loops. ... > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki- > semi/pch_gbe/pch_gbe_main.c > index 00ef83c..87994d2 100644 > --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c > @@ -321,7 +321,7 @@ static void pch_gbe_wait_clr_bit(void *reg, u32 bit) > u32 tmp; > > /* wait busy */ > - tmp = 1000; > + tmp = 10000; > while ((ioread32(reg) & bit) && --tmp) > cpu_relax(); > if (!tmp) Why not sleep for (say) 100us ? That'll stop the loop depending on the cpu speed. David