From: David Laight <David.Laight@ACULAB.COM>
To: "'Karicheri, Muralidharan'" <m-karicheri2@ti.com>,
"Strashko, Grygorii" <grygorii.strashko@ti.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Arnd Bergmann" <arnd@arndb.de>
Cc: "Cooper Jr., Franklin" <fcooper@ti.com>,
"Nori, Sekhar" <nsekhar@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kwok, WingMan" <w-kwok2@ti.com>,
"N, Mugunthan V" <mugunthanvnm@ti.com>
Subject: RE: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality
Date: Tue, 9 Feb 2016 16:37:43 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CCDC216@AcuExch.aculab.com> (raw)
In-Reply-To: <3E54258959B69E4282D79E01AB1F32B704D12B40@DFLE11.ent.ti.com>
From: Karicheri, Muralidharan
> Sent: 09 February 2016 16:19
> >...
> >> >In reality the 'pad' fields ought to be renamed - since they aren't pads.
> >> >Perhaps they should be a union?
> >
> >> No. At the end of the descriptor, host software can add scratchpad
> >> which is not modified by the hardware, but is used by the driver. So
> >> please don't rename.
> >
> >So comment in the definition that the hardware doesn't modify them.
> >The driver is defining these fields and they are definitely NOT padding.
>
>
> It is scratch pad, not padding. Looks like pad is a confusing name. Can be
> renamed to sw_data to be in sync with spec below.
>
> The hardware spec from
> http://www.ti.com/lit/ug/sprugr9h/sprugr9h.pdf
>
> The other SW data portion of the descriptor exists after all of the defined
> words and is reserved for use by the host software to store completely
> private data. This region is not used in any way by the DMA or queue manager
> modules in a Multicore Navigator system and these modules will not modify
> any bytes within this region.
Right, so comment that the hardware doesn't look at the fields.
But name/type the structure fields to indicate what they contain.
Maybe sw_buf_len etc - but I suspect there are much more meaningful names.
David
next prev parent reply other threads:[~2016-02-09 16:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 13:58 Grygorii Strashko
2016-02-09 14:13 ` David Laight
2016-02-09 16:09 ` Karicheri, Muralidharan
2016-02-09 16:10 ` David Laight
2016-02-09 16:19 ` Karicheri, Muralidharan
2016-02-09 16:37 ` David Laight [this message]
2016-02-09 16:55 ` Karicheri, Muralidharan
2016-02-09 19:38 ` Arnd Bergmann
2016-02-10 8:33 ` Grygorii Strashko
2016-02-17 16:19 ` Murali Karicheri
2016-02-18 17:02 ` Murali Karicheri
2016-02-16 20:24 ` David Miller
2016-02-18 17:13 ` Murali Karicheri
2016-02-18 20:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6D1CCDC216@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=fcooper@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®