From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756477AbaAJKRt (ORCPT ); Fri, 10 Jan 2014 05:17:49 -0500 Received: from mx0.aculab.com ([213.249.233.131]:38135 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753455AbaAJKRr (ORCPT ); Fri, 10 Jan 2014 05:17:47 -0500 From: David Laight To: "'Shahed Shaikh'" , Martin Kaiser , Himanshu Madhani , "Rajesh Borundia" CC: linux-kernel , "trivial@kernel.org" , netdev Subject: RE: [PATCH -next] qlcnic: fix compiler warning Thread-Topic: [PATCH -next] qlcnic: fix compiler warning Thread-Index: AQHPDWjikF1O4m47uESqJjMVu9vJI5p9i3AQgAAxNLA= Date: Fri, 10 Jan 2014 10:15:54 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D45796C@AcuExch.aculab.com> References: <20140109155908.GA4351@reykholt.kaiser.cx> <262CB373A6D1F14F9B81E82F74F77D5A46F52B8E@avmb2.qlogic.org> In-Reply-To: <262CB373A6D1F14F9B81E82F74F77D5A46F52B8E@avmb2.qlogic.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s0AAHtk5008463 From: Shahed Shaikh > Adding netdev. > > > -----Original Message----- > > From: Martin Kaiser,,, [mailto:martin@reykholt.kaiser.cx] On Behalf Of > > Martin Kaiser > > Sent: Thursday, January 09, 2014 9:29 PM > > To: Himanshu Madhani; Rajesh Borundia > > Cc: linux-kernel; trivial@kernel.org > > Subject: [PATCH -next] qlcnic: fix compiler warning > > > > Add an explicit cast to fix the following warning (seen on Debian Wheezy, gcc > > 4.7.2) > > > > CC [M] drivers/net/wireless/rtlwifi/rtl8192ce/trx.o > > drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c: In function > > qlcnic_send_filter: > > drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:349:3: warning: > > passing argument 2 of ether_addr_equal from incompatible pointer type > > [enabled by default] > > In file included from include/linux/if_vlan.h:16:0, > > from drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:9: > > include/linux/etherdevice.h:244:20: note: expected const u8 * but > > argument is of type u64 * > > > > If I am not wrong, this patch should go to David's net-next tree. > > > Signed-off-by: Martin Kaiser > > Acked-by: Shahed Shaikh > > Thanks, > Shahed > > --- > > drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c > > b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c > > index 6373f60..3557154 100644 > > --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c > > +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c > > @@ -346,7 +346,7 @@ static void qlcnic_send_filter(struct qlcnic_adapter > > *adapter, > > head = &(adapter->fhash.fhead[hindex]); > > > > hlist_for_each_entry_safe(tmp_fil, n, head, fnode) { > > - if (ether_addr_equal(tmp_fil->faddr, &src_addr) && > > + if (ether_addr_equal(tmp_fil->faddr, (const u8 *)&src_addr) > > && > > tmp_fil->vlan_id == vlan_id) { > > if (jiffies > (QLCNIC_READD_AGE * HZ + tmp_fil- > > >ftime)) > > qlcnic_change_filter(adapter, &src_addr, > > -- > > 1.7.10.4 A quick look at the code seems to imply that this code is somewhat buggy. 'src_addr' is defined a u64 even though it is a 6 byte mac address. On big-endian systems the wrong bytes get accessed all over the place. Also when ether_addr_equal() in inlined the code ends up accessing src_addr as 32bit and 16bit data - which don't have to be synchronised against and writes to the 64bit item. If might be that ether_addr_equal() (etc) should have a gcc asm statement with a "memory" constraint against the mac address buffers. David {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I