From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943199AbcJaNp0 convert rfc822-to-8bit (ORCPT ); Mon, 31 Oct 2016 09:45:26 -0400 Received: from smtp-out6.electric.net ([192.162.217.193]:56059 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943123AbcJaNpY (ORCPT ); Mon, 31 Oct 2016 09:45:24 -0400 From: David Laight To: "'Nicolas Iooss'" , Armin Schindler , Karsten Keil CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/4] isdn/eicon: fix some message formatting errors Thread-Topic: [PATCH 2/4] isdn/eicon: fix some message formatting errors Thread-Index: AQHSMePQr6wOTcIu2ESKutXGKQSTfaDClLOQ Date: Mon, 31 Oct 2016 13:42:18 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB020E4AB@AcuExch.aculab.com> References: <20161029125605.13610-1-nicolas.iooss_linux@m4x.org> <20161029125605.13610-2-nicolas.iooss_linux@m4x.org> In-Reply-To: <20161029125605.13610-2-nicolas.iooss_linux@m4x.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicolas Iooss > Sent: 29 October 2016 13:56 > There are some inconsistent debug message formats in message.c. For > example, > > dprintf("XDI CAPI: RC cancelled Id:0x02, Ch:%02x", e->Id, ch); > > wrongly reports an ID of 2 and prints the entity ID as the channel ID. > There are also object pointers which are used instead of the IDs. > > All these inconsistent formats have been found by adding __printf > attribute to myDbgPrint_...() functions (used by dbug()). As this makes > the compiler to also complain about using "%ld" with unsigned int values > (instead of "%u")... The problem isn’t 'u' <=> 'd' but the 'l'. They need fixing as well. It only appears to work because the 64bit architectures pass enough arguments in registers. David