From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932854AbcLMMlI convert rfc822-to-8bit (ORCPT ); Tue, 13 Dec 2016 07:41:08 -0500 Received: from smtp-out4.electric.net ([192.162.216.190]:59976 "EHLO smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbcLMMlG (ORCPT ); Tue, 13 Dec 2016 07:41:06 -0500 X-Greylist: delayed 1246 seconds by postgrey-1.27 at vger.kernel.org; Tue, 13 Dec 2016 07:41:05 EST From: David Laight To: "'Andy Lutomirski'" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "dhowells@redhat.com" , "keyrings@vger.kernel.org" CC: Eric Biggers , "linux-crypto@vger.kernel.org" , Herbert Xu , Stephan Mueller Subject: RE: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs Thread-Topic: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs Thread-Index: AQHSVLnVPHdcnb43gEWSSdktY3TBlqEFzGYQ Date: Tue, 13 Dec 2016 12:20:08 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB023CA99@AcuExch.aculab.com> References: <8c273c9c41f51b34bb3115086f1d776895580637.1481575835.git.luto@kernel.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Lutomirski > Sent: 12 December 2016 20:53 > The driver put a constant buffer of all zeros on the stack and > pointed a scatterlist entry at it in two places. This doesn't work > with virtual stacks. Use a static 16-byte buffer of zeros instead. ... I didn't think you could dma from static data either. David