From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759669AbdADMW1 convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Jan 2017 07:22:27 -0500
Received: from smtp-out6.electric.net ([192.162.217.191]:52018 "EHLO
        smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753304AbdADMWY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2017 07:22:24 -0500
From: David Laight <David.Laight@ACULAB.COM>
To: "'Harisangam, Sharvari (S.)'" <sharvari.harisangam@visteon.com>,
        "Timur Tabi" <timur@tabi.org>, Nicolin Chen <nicoleotsuka@gmail.com>,
        Xiubo Li <Xiubo.Lee@gmail.com>, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.de>
CC: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH]  ASoC : fsl_ssi : Correct the condition to check AC97
 mode
Thread-Topic: [PATCH]  ASoC : fsl_ssi : Correct the condition to check AC97
 mode
Thread-Index: AQHSYPp5twBSGFk3L0S3wYx3dU5J3aEoSCIQ
Date: Wed, 4 Jan 2017 12:22:09 +0000
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB025783A@AcuExch.aculab.com>
References: <20161228110636.GA14768@ubuntu>
In-Reply-To: <20161228110636.GA14768@ubuntu>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.202.99.200]
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-Outbound-IP: 213.249.233.130
X-Env-From: David.Laight@ACULAB.COM
X-Proto: esmtps
X-Revdns: 
X-HELO: AcuExch.aculab.com
X-TLS: TLSv1:AES128-SHA:128
X-Authenticated_ID: 
X-PolicySMART: 3396946, 3397078
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Harisangam, Sharvari (S.)
> Sent: 28 December 2016 11:07
>  Corrected the condition to check if ssi is configured for AC97
>  mode. Other modes like dsp_a also satisfy the ANDing condition.

Under the assumption that the constants have 1 bit set nothing is wrong.

	David

...
> -	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97);
...
> -	if (fmt & SND_SOC_DAIFMT_AC97)
...