From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbdCOIuS convert rfc822-to-8bit (ORCPT ); Wed, 15 Mar 2017 04:50:18 -0400 Received: from smtp-out6.electric.net ([192.162.217.190]:52573 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbdCOIuQ (ORCPT ); Wed, 15 Mar 2017 04:50:16 -0400 From: David Laight To: "'Shannon Nelson'" , "netdev@vger.kernel.org" , "davem@davemloft.net" CC: "sparclinux@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets Thread-Topic: [PATCH v2 net-next 4/5] sunvnet: count multicast packets Thread-Index: AQHSnOjAdsIEYHgWFEeAHiHsG6OWV6GVl4qg Date: Wed, 15 Mar 2017 08:50:05 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFB12CF@AcuExch.aculab.com> References: <1489512283-422140-1-git-send-email-shannon.nelson@oracle.com> <1489512283-422140-5-git-send-email-shannon.nelson@oracle.com> In-Reply-To: <1489512283-422140-5-git-send-email-shannon.nelson@oracle.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shannon Nelson > Sent: 14 March 2017 17:25 ... > + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) > + dev->stats.multicast++; I'd guess that: dev->stats.multicast += is_multicast_ether_addr(eth_hdr(skb)->h_dest); generates faster code. Especially if is_multicast_ether_addr(x) is (*x >> 7). David