From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753649AbdESKtE convert rfc822-to-8bit (ORCPT ); Fri, 19 May 2017 06:49:04 -0400 Received: from smtp-out4.electric.net ([192.162.216.182]:54314 "EHLO smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbdESKtC (ORCPT ); Fri, 19 May 2017 06:49:02 -0400 From: David Laight To: "'Christoph Hellwig'" , Thomas Gleixner CC: Tejun Heo , "linuxppc-dev@lists.ozlabs.org" , Mark Gross , "linux-kernel@vger.kernel.org" , "linux-s390@vger.kernel.org" Subject: RE: [PATCH 2/9] timers: provide a "modern" variant of timers Thread-Topic: [PATCH 2/9] timers: provide a "modern" variant of timers Thread-Index: AQHSzjtByenPWqBISE+pMiJgloRZDKH7fUxg Date: Fri, 19 May 2017 10:48:51 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFFAA38@AcuExch.aculab.com> References: <20170516114812.10660-1-hch@lst.de> <20170516114812.10660-3-hch@lst.de> In-Reply-To: <20170516114812.10660-3-hch@lst.de> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig > Sent: 16 May 2017 12:48 > > The new callback gets a pointer to the timer_list itself, which can > then be used to get the containing structure using container_of > instead of casting from and to unsigned long all the time. What about sensible drivers that put some other value in the 'data' field? Perhaps it ought to have been 'void *data'. Seems retrograde to be passing the address of the timer structure (which, in principle, the callers no nothing about). So I wouldn't call it 'modern', just different. David