From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbdHOKmt convert rfc822-to-8bit (ORCPT ); Tue, 15 Aug 2017 06:42:49 -0400 Received: from smtp-out4.electric.net ([192.162.216.189]:52105 "EHLO smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753554AbdHOKms (ORCPT ); Tue, 15 Aug 2017 06:42:48 -0400 From: David Laight To: "'Jonathan Corbet'" , Corcodel Marian CC: "netdev@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Realtek linux nic maintainers" Subject: RE: [PATCH] New Chapter on CodingStyle . Thread-Topic: [PATCH] New Chapter on CodingStyle . Thread-Index: AQHTE3r8298Pgz2FUkmx+vjf59N0AKKFPtBQ Date: Tue, 15 Aug 2017 10:42:39 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD0055A0C@AcuExch.aculab.com> References: <1502536998-5482-1-git-send-email-asd@marian1000.go.ro> <20170812085439.573c6c55@lwn.net> In-Reply-To: <20170812085439.573c6c55@lwn.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Corbet > Sent: 12 August 2017 15:55 ... > > + Chapter 20: Put values on initialisers without exception > > + > > +When declaring variables on functions must put values: > > Thanks for sending a patch for the kernel's documentation. > Unfortunately, I can't accept this patch for a couple of reasons: ... > - The coding style document is there to describe the community's > standards for kernel code. It is *not* a mechanism for imposing new > standards. If you really think that the kernel community should adopt > this rule, you will need to argue for it on the mailing lists. I will > say, though, that I do not expect that this effort would be successful. I'd even go as far as suggesting almost the opposite. Declarations should only have initialisers if the value is constant. David