From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753740AbdHUOwq convert rfc822-to-8bit (ORCPT ); Mon, 21 Aug 2017 10:52:46 -0400 Received: from smtp-out6.electric.net ([192.162.217.182]:63272 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210AbdHUOwo (ORCPT ); Mon, 21 Aug 2017 10:52:44 -0400 From: David Laight To: "'Dan Carpenter'" , Jarod Wilson CC: "David S. Miller" , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , Ilya Matveychikov , Baoquan He , Andrew Morton , Ingo Molnar , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH net] ethernet: xircom: small clean up in setup_xirc2ps_cs() Thread-Topic: [PATCH net] ethernet: xircom: small clean up in setup_xirc2ps_cs() Thread-Index: AQHTGmLSszbTXRi7LEKTm2TlfF+mbKKO5RYw Date: Mon, 21 Aug 2017 14:52:34 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD005CC34@AcuExch.aculab.com> References: <20170821094730.ydm2xwsqbkyadybi@mwanda> In-Reply-To: <20170821094730.ydm2xwsqbkyadybi@mwanda> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter > Sent: 21 August 2017 10:48 > The get_options() function takes the whole ARRAY_SIZE(). It doesn't > matter here because we don't use more than 7 elements. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/ethernet/xircom/xirc2ps_cs.c b/drivers/net/ethernet/xircom/xirc2ps_cs.c > index f71883264cc0..fd5288ff53b5 100644 > --- a/drivers/net/ethernet/xircom/xirc2ps_cs.c > +++ b/drivers/net/ethernet/xircom/xirc2ps_cs.c > @@ -1781,7 +1781,7 @@ static int __init setup_xirc2ps_cs(char *str) > */ > int ints[10] = { -1 }; > > - str = get_options(str, 9, ints); > + str = get_options(str, ARRAY_SIZE(ints), ints); > > #define MAYBE_SET(X,Y) if (ints[0] >= Y && ints[Y] != -1) { X = ints[Y]; } > MAYBE_SET(if_port, 3); That code looks very dubious to me. It looks as though it expects all of the ints[] array to be initialised to -1, not just the first element. David