From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093AbdJIJPW (ORCPT ); Mon, 9 Oct 2017 05:15:22 -0400 Received: from smtp-out4.electric.net ([192.162.216.185]:51838 "EHLO smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdJIJPU (ORCPT ); Mon, 9 Oct 2017 05:15:20 -0400 From: David Laight To: "'Kees Cook'" , Paul Bolle CC: Karsten Keil , "David S. Miller" , Johan Hovold , LKML , "gigaset307x-common@lists.sourceforge.net" , Network Development Subject: RE: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup() Thread-Topic: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup() Thread-Index: AQHTPtVu5Hz4110NoEuPlfGz//n6m6LXJ1gAgAQYl3A= Date: Mon, 9 Oct 2017 09:15:17 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD008D392@AcuExch.aculab.com> References: <20171005193118.GA105874@beast> <1507316433.6960.19.camel@tiscali.nl> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v999FRql028987 From: Kees Cook > Sent: 06 October 2017 20:40 ... > I'm in no rush for any specific change. There are about 900 call sites > I'm making my way through, about 2/3rd are pretty trivial, and the > less obvious is what I've started sending out now, since I expect some > will need some more careful review. Is it worth adding a structure that contains a timer and an extra 'long' than can be used to maintain the existing API logic for the 'difficult' cases? David