From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752772AbdJKKI1 convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 11 Oct 2017 06:08:27 -0400
Received: from smtp-out4.electric.net ([192.162.216.194]:62291 "EHLO
        smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751080AbdJKKIZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Oct 2017 06:08:25 -0400
From: David Laight <David.Laight@ACULAB.COM>
To: "'Jesper Dangaard Brouer'" <brouer@redhat.com>,
        Christina Jacob <christina.jacob.koikara@gmail.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "Sunil.Goutham@cavium.com" <Sunil.Goutham@cavium.com>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "dsahern@gmail.com" <dsahern@gmail.com>,
        Christina Jacob <Christina.Jacob@cavium.com>
Subject: RE: [PATCH v2] xdp: Sample xdp program implementing ip forward
Thread-Topic: [PATCH v2] xdp: Sample xdp program implementing ip forward
Thread-Index: AQHTQfrbt4y6tx+vxE+Agbsav31jKaLebVPw
Date: Wed, 11 Oct 2017 10:08:21 +0000
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD0090EEE@AcuExch.aculab.com>
References: <1507620532-25804-1-git-send-email-Christina.Jacob@cavium.com>
        <1507620532-25804-2-git-send-email-Christina.Jacob@cavium.com>
 <20171010210607.2af452e2@redhat.com>
In-Reply-To: <20171010210607.2af452e2@redhat.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.202.99.200]
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-Outbound-IP: 156.67.243.126
X-Env-From: David.Laight@ACULAB.COM
X-Proto: esmtps
X-Revdns: 
X-HELO: AcuExch.aculab.com
X-TLS: TLSv1:AES128-SHA:128
X-Authenticated_ID: 
X-PolicySMART: 3396946, 3397078
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jesper Dangaard Brouer
> Sent: 10 October 2017 20:06
...
> > +		int src_ip = 0, dest_ip = 0;
...
> > +			key4.b8[4] = dest_ip % 0x100;
> > +			key4.b8[5] = (dest_ip >> 8) % 0x100;
> > +			key4.b8[6] = (dest_ip >> 16) % 0x100;
> > +			key4.b8[7] = (dest_ip >> 24) % 0x100;

Do you really want signed remainders done here?

	David