From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "linux-imx@nxp.com" <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v4 12/17] arm64: dts: freescale: apalis-imx8: analogue audio comment
Date: Wed, 18 Jan 2023 15:36:22 +0100 [thread overview]
Message-ID: <063d98af-7b9b-c918-6436-5402265628fa@linaro.org> (raw)
In-Reply-To: <da7cf752c820e1c2cda5de4865c33d1b1e7247cf.camel@toradex.com>
On 18/01/2023 15:33, Marcel Ziswiler wrote:
> On Wed, 2023-01-18 at 14:59 +0100, Krzysztof Kozlowski wrote:
>> On 18/01/2023 08:26, Marcel Ziswiler wrote:
>>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>>
>>> Added a comment about Apalis analogue audio being another todo.
>>>
>>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>
>> You just added this file in previous patch. This should be squashed
>> instead of splitting one logical change (adding new hardware) into
>> multiple independent patches.
>
> Remember, I explicitly did that for review purpose and even mentioned this in the cover letter.
There is b4 diff for this purpose. Splitting patches makes them
difficult to apply and confuse.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-18 14:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 7:26 [PATCH v4 00/17] arm64: dts: freescale: prepare and add apalis imx8 support Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 01/17] arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3 Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 02/17] arm64: dts: imx8-ss-dma: add io-channel-cells to adc nodes Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 03/17] arm64: dts: freescale: imx8-ss-dma: set lpspi0 max frequency to 60mhz Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 04/17] firmware: imx: scu-pd: add missed lvds lpi2c and pwm power domains Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 05/17] arm64: dts: imx8qm: add pwm_lvds0/1 support Marcel Ziswiler
2023-01-18 8:47 ` Liu Ying
2023-01-18 13:31 ` Marcel Ziswiler
2023-01-19 1:23 ` Liu Ying
2023-01-18 7:26 ` [PATCH v4 06/17] arm64: dts: imx8qxp: add flexcan in adma Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 07/17] arch: arm64: imx8qm: add can node in devicetree Marcel Ziswiler
2023-01-18 13:58 ` Krzysztof Kozlowski
2023-01-18 14:32 ` Marcel Ziswiler
2023-01-18 14:35 ` Krzysztof Kozlowski
2023-01-18 7:26 ` [PATCH v4 08/17] arm64: dts: imx8qm: add vpu decoder and encoder Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 09/17] dt-bindings: arm: fsl: add toradex,apalis-imx8 et al Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 10/17] arm64: dts: freescale: add initial apalis imx8 aka quadmax module support Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 11/17] arm64: dts: freescale: add apalis imx8 aka quadmax carrier board support Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 12/17] arm64: dts: freescale: apalis-imx8: analogue audio comment Marcel Ziswiler
2023-01-18 13:59 ` Krzysztof Kozlowski
2023-01-18 14:33 ` Marcel Ziswiler
2023-01-18 14:36 ` Krzysztof Kozlowski [this message]
2023-01-18 7:26 ` [PATCH v4 13/17] arm64: dts: freescale: apalis-imx8: add bkl1_pwm functionality Marcel Ziswiler
2023-01-18 14:00 ` Krzysztof Kozlowski
2023-01-18 14:34 ` Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 14/17] arm64: dts: freescale: apalis-imx8: add flexcan functionality Marcel Ziswiler
2023-01-18 14:01 ` Krzysztof Kozlowski
2023-01-18 14:34 ` Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 15/17] arm64: dts: freescale: apalis-imx8: enable messaging units Marcel Ziswiler
2023-01-18 14:01 ` Krzysztof Kozlowski
2023-01-18 14:35 ` Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 16/17] arm64: dts: freescale: apalis-imx8: fix reserved-memory node names Marcel Ziswiler
2023-01-18 14:02 ` Krzysztof Kozlowski
2023-01-18 14:36 ` Marcel Ziswiler
2023-01-18 14:37 ` Krzysztof Kozlowski
2023-01-18 14:42 ` Marcel Ziswiler
2023-01-18 7:26 ` [PATCH v4 17/17] arm64: dts: freescale: apalis-imx8: enable vpu Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063d98af-7b9b-c918-6436-5402265628fa@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®