From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A63CD43E490 for ; Wed, 6 May 2026 12:28:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778070492; cv=none; b=qb4/ZP8L54UyXDBF7lmbATBSWe/CK8eafY/onvFM99DFrMAcoOlJ04mN914ejbeZWKowo9RkfH4iAk8vS1388OgrREqORAualqJDJN/PnSDHyd7AHdqxR+P1z3g9DZ/nAS9rNsUmUpw/3S6PHOPkyHmgBA/5C0pMasqi4nUOT28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778070492; c=relaxed/simple; bh=vclG0yxAvF+A/2roV7osqFbBYgf+u0vUuYzd2t5GLzg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hPYYJRdHuQyJcj2naI09sW5T1AHzGlK5YeAfHEDfGbbb4sNXywjI0IWgCXQWUkNAqo0GDD3RrY3cb8ErpE9Hk0vmSPt0aHn5jv1VHO71DaUZDvxTXYtI9QUm8UnZbZ57/1GejjI2zaRk0R1eYc8VSfKChvOO2N13QFpoYW2BPsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xskv7F1R; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xskv7F1R" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488a88aeec9so71536805e9.2 for ; Wed, 06 May 2026 05:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778070489; x=1778675289; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fgsWJ43+sPMyFM6YZi9dneb609gv57UFa/hUFdFYocw=; b=xskv7F1RGtGi8zD/UnbdcgR1YZziglp0fHeiJ2Z4aWoTi73VyKgyRHiq1KaZehrBjK Lg+KIP6pWBH2Ugy8gIsXOHD5XTWYoBF3aXgatwTV8dHrxyBs0VtXfr8xmVJXFT7UksP5 waZq9xtMoKoT1YaJ4SnsmReRHGNWLsT4giytb2h/OsPHObT629UyIGx+h3u1oQq2kbTu txHKxzhvC9iM+p/jasZTkQqRW18yHtujShomKocfvTySM3etJAafb3NoZJ/TrFm+/gIQ wsS6ygZ/izRtWQYGJikLnGQFti8MTr0R49lTPYLKJE1PNHNrHmMQCtyXzYOfTHEYissc guxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778070489; x=1778675289; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fgsWJ43+sPMyFM6YZi9dneb609gv57UFa/hUFdFYocw=; b=Isxk3CaNEERbUvjJqI7TKYTVPRdIgOMr7oTUB5TFZHxYh7quoNFP3CgGYgbhqkKN/N gQsCUgVooHOCwWPiJs3dz699qTJ/rtHkEryzCo4WA98XmJjZi84iqmWrp2LtItrkdVVt vK4bqVj0czp9kojuHrScNdpy+7yGMEcF5W/L00UriSeJp6c/JGinPaYrZAZhs7+YCr0K KF0g0Ot8OH14BV6cOCMRfI9VX/R6J/v2xj8mSVC2JDn6LGyHbI32RDSNrbkTcKiqLBgS 3ufVjv0Bz266L3INqCZbvbnuy1N8mZtXZD76B6AUaHjVANHQWmJyo1huC0PTpM5pwG+7 gfuA== X-Forwarded-Encrypted: i=1; AFNElJ9/Y7kdewsmBE4oEtKdIqLqtgt7u5lRjhVqZTpetJ45UCfW0zRGs/yDV5aH2m88c++YLXIDU8IGg2A3YPs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/svdcZ26VZAfSd+VzFabVIuplRFT8PnQdy7mSHpmPz59BJOKD MpM89NY/CFgJSdwggt8+GzUEn4d2i0Wat3SxXSCASoUJkZbS6rLCPka85MchiyAiY8M= X-Gm-Gg: AeBDievlAiVtmZ01S+IKQIo9u/b4jaztSxpkBZMl0F2eePVKsh5R3vKHCDhT8cF9j2P CdUPrJQooCYmS3HbeQVyttpGqD3h9nFFvLP4v+O0w40BEGqZc8zxnhOjkwS+VdC5VWyH0fLlT+H na0aod5aOfgEBgeAmbBDGWP7CfwgY0Hbp6MrfjVOqaZJZpnfH4qECps19F6slDbrBoAStb066PR bMccUyVosnaUdmOnADQuqylcBPLIJdDQSdjyXYISJwhuvcHcFf6bSwR4ApL5VPFveX97tEAZYlj PJNvmfdyftd4tcL4M0aX6Tj9vfNnRHkJH35Qr59aHEABY140qyV01U6U1IUugCzW2xDj/4oMdaC Zymlsya+9uBqOq7WAuxoeKM1TZdL20fu390zUF9OjJwo9vnlVQPILw2DgTr1dfsoMoHhT41OyFL c4jUXISZLpXeNAb1FxXnivYF4JCIvycCZ9j4rol352S2M= X-Received: by 2002:a05:600c:811a:b0:489:1c32:210d with SMTP id 5b1f17b1804b1-48e51f369c3mr57793395e9.15.1778070489168; Wed, 06 May 2026 05:28:09 -0700 (PDT) Received: from [10.11.12.108] ([79.115.63.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e539109b7sm41077585e9.15.2026.05.06.05.28.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 05:28:08 -0700 (PDT) Message-ID: <06406c7b-c141-4997-9921-9358cdea7641@linaro.org> Date: Wed, 6 May 2026 15:28:05 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] spi: s3c64xx: fix all kernel-doc warnings To: Randy Dunlap , linux-kernel@vger.kernel.org, Mark Brown Cc: Krzysztof Kozlowski , Andi Shyti , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Juan Yescas , Peter Griffin , =?UTF-8?Q?Andr=C3=A9_Draszik?= References: <20260416224056.985233-1-rdunlap@infradead.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <20260416224056.985233-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi! You missed adding the SPI maintainer. +Mark. Also, there's another kdoc warning in that file. Do you care to fix it? scripts/kernel-doc -none include/linux/platform_data/spi-s3c64xx.h Warning: include/linux/platform_data/spi-s3c64xx.h:40 struct member 'polling' not described in 's3c64xx_spi_info' Warning: include/linux/platform_data/spi-s3c64xx.h:51 expecting prototype for s3c64xx_spi_set_platdata(). Prototype was for s3c64xx_spi0_set_platdata() instead Cheers, ta On 4/17/26 1:40 AM, Randy Dunlap wrote: > Add kernel-doc for one struct member and use the correct function name > to eliminate kernel-doc warnings: > > Warning: include/linux/platform_data/spi-s3c64xx.h:40 struct member > 'polling' not described in 's3c64xx_spi_info' > Warning: include/linux/platform_data/spi-s3c64xx.h:51 expecting prototype > for s3c64xx_spi_set_platdata(). Prototype was for > s3c64xx_spi0_set_platdata() instead > > Signed-off-by: Randy Dunlap > Reviewed-by: Krzysztof Kozlowski > --- > v2: add tag; rebase & resend > > Cc: Andi Shyti > Cc: Tudor Ambarus > Cc: linux-spi@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > > include/linux/platform_data/spi-s3c64xx.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-next-20260415.orig/include/linux/platform_data/spi-s3c64xx.h > +++ linux-next-20260415/include/linux/platform_data/spi-s3c64xx.h > @@ -30,6 +30,7 @@ struct s3c64xx_spi_csinfo { > * @src_clk_nr: Clock source index for the CLK_CFG[SPI_CLKSEL] field. > * @num_cs: Number of CS this controller emulates. > * @no_cs: Used when CS line is not connected. > + * @polling: Using polling mode when %true (no 'dmas' property in devicetree) > * @cfg_gpio: Configure pins for this SPI controller. > */ > struct s3c64xx_spi_info { > @@ -41,7 +42,7 @@ struct s3c64xx_spi_info { > }; > > /** > - * s3c64xx_spi_set_platdata - SPI Controller configure callback by the board > + * s3c64xx_spi0_set_platdata - SPI Controller configure callback by the board > * initialization code. > * @src_clk_nr: Clock the SPI controller is to use to generate SPI clocks. > * @num_cs: Number of elements in the 'cs' array.