mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Decotigny <david.decotigny@google.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Ian Campbell <ian.campbell@citrix.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Ben Hutchings <bhutchings@solarflare.com>,
	David Decotigny <david.decotigny@google.com>
Subject: [PATCH net-next v1 6/9] forcedeth: account for dropped RX frames
Date: Wed,  9 Nov 2011 14:09:20 -0800	[thread overview]
Message-ID: <06463c792db6a8b0abbd71c67cfbb8f1569729f3.1320875577.git.david.decotigny@google.com> (raw)
In-Reply-To: <cover.1320875577.git.david.decotigny@google.com>
In-Reply-To: <cover.1320875577.git.david.decotigny@google.com>

This adds the stats counter for dropped RX frames.



Signed-off-by: David Decotigny <david.decotigny@google.com>
---
 drivers/net/ethernet/nvidia/forcedeth.c |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 0b4fd1a..85e34b6c 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -818,6 +818,7 @@ struct fe_priv {
 	u32 nic_poll_irq;
 	int rx_ring_size;
 	struct nv_driver_stat stat_rx_missed_errors;
+	struct nv_driver_stat stat_rx_dropped;
 
 	/* media detection workaround.
 	 * Locking: Within irq hander or disable_irq+spin_lock(&np->lock);
@@ -1727,6 +1728,7 @@ static void nv_update_stats(struct net_device *dev)
 	}
 
 	/* update software stats */
+	NV_DRIVER_STAT_UPDATE_TOTAL(&np->stat_rx_dropped);
 	NV_DRIVER_STAT_UPDATE_TOTAL(&np->stat_tx_dropped);
 	NV_DRIVER_STAT_UPDATE_TOTAL(&np->stat_rx_missed_errors);
 }
@@ -1759,6 +1761,8 @@ nv_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *storage)
 		storage->tx_bytes   = np->estats.tx_bytes;
 		storage->rx_errors  = np->estats.rx_errors_total;
 		storage->tx_errors  = np->estats.tx_errors_total;
+		storage->rx_dropped = NV_DRIVER_STAT_GET_TOTAL(
+			&np->stat_rx_dropped);
 		storage->tx_dropped = NV_DRIVER_STAT_GET_TOTAL(
 			&np->stat_tx_dropped);
 		storage->multicast  = np->estats.rx_multicast;
@@ -1812,8 +1816,10 @@ static int nv_alloc_rx(struct net_device *dev)
 				np->put_rx.orig = np->first_rx.orig;
 			if (unlikely(np->put_rx_ctx++ == np->last_rx_ctx))
 				np->put_rx_ctx = np->first_rx_ctx;
-		} else
+		} else {
+			NV_DRIVER_STAT_ATOMIC_INC(&np->stat_rx_dropped);
 			return 1;
+		}
 	}
 	return 0;
 }
@@ -1844,8 +1850,10 @@ static int nv_alloc_rx_optimized(struct net_device *dev)
 				np->put_rx.ex = np->first_rx.ex;
 			if (unlikely(np->put_rx_ctx++ == np->last_rx_ctx))
 				np->put_rx_ctx = np->first_rx_ctx;
-		} else
+		} else {
+			NV_DRIVER_STAT_ATOMIC_INC(&np->stat_rx_dropped);
 			return 1;
+		}
 	}
 	return 0;
 }
-- 
1.7.3.1


  parent reply	other threads:[~2011-11-09 22:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09 22:09 [PATCH net-next v1 0/9] forcedeth: stats & debug enhancements David Decotigny
2011-11-09 22:09 ` [PATCH net-next v1 1/9] forcedeth: Add messages to indicate using MSI or MSI-X David Decotigny
2011-11-09 22:09 ` [PATCH net-next v1 2/9] forcedeth: allow to silence "TX timeout" debug messages David Decotigny
2011-11-09 22:09 ` [PATCH net-next v1 3/9] forcedeth: expose module parameters in /sys/module David Decotigny
2011-11-09 22:09 ` [PATCH net-next v1 4/9] forcedeth: stats for rx_packets based on hardware registers David Decotigny
2011-11-10 18:45   ` David Decotigny
2011-11-09 22:09 ` [PATCH net-next v1 5/9] forcedeth: implement ndo_get_stats64() API David Decotigny
2011-11-09 23:43   ` Ben Hutchings
2011-11-09 22:09 ` David Decotigny [this message]
2011-11-09 22:09 ` [PATCH net-next v1 7/9] forcedeth: new ethtool stat counter for TX timeouts David Decotigny
2011-11-09 22:09 ` [PATCH net-next v1 8/9] forcedeth: stats updated with a deferrable timer David Decotigny
2011-11-09 22:09 ` [PATCH net-next v1 9/9] forcedeth: whitespace/indentation fixes David Decotigny
2011-11-09 23:41 ` [PATCH net-next v1 0/9] forcedeth: stats & debug enhancements Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06463c792db6a8b0abbd71c67cfbb8f1569729f3.1320875577.git.david.decotigny@google.com \
    --to=david.decotigny@google.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=ian.campbell@citrix.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®