From: Dan Scally <dan.scally@ideasonboard.com>
To: Nicola Fiorillo <nicfio@gmail.com>, linux-media@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Hans de Goede <hansg@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: ipu-bridge: Add GalaxyCore GC5035 and GC8034
Date: Fri, 9 Oct 2026 10:24:08 +0100 [thread overview]
Message-ID: <06479beb-4f83-40d0-85c7-a4545e963cbf@ideasonboard.com> (raw)
In-Reply-To: <20261009072733.39877-4-nicfio@gmail.com>
Morning Nicola
On 09/10/2026 08:27, Nicola Fiorillo wrote:
> Add the GC5035 and GC8034 ACPI HIDs, with the link frequencies the two
> sensors use with a 19.2 MHz external clock. Both are found on the CHUWI
> Hi10 X1.
>
> Assisted-by: claude-opus-5-5
> Signed-off-by: Nicola Fiorillo <nicfio@gmail.com>
> ---
> drivers/media/pci/intel/ipu-bridge.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index 3739c4a2a..851096d7d 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -59,6 +59,10 @@ static const u16 ipu6_ov5693_ncont_clk[] = {
> };
>
> static const struct ipu_sensor_config ipu_supported_sensors[] = {
> + /* GalaxyCore GC5035 */
> + IPU_SENSOR_CONFIG("GCTI5035", 1, 422400000),
> + /* GalaxyCore GC8034 */
> + IPU_SENSOR_CONFIG("GCTI8034", 1, 268800000),
These entries look ok:
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> /* Himax HM1092 */
> IPU_SENSOR_CONFIG("HIMX1092", 2, 180000000, 180480000),
> /* Himax HM11B1 */
prev parent reply other threads:[~2026-10-09 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 7:27 [PATCH 0/3] media: Add GalaxyCore GC5035 and GC8034 sensor drivers Nicola Fiorillo
2026-10-09 7:27 ` [PATCH 1/3] media: i2c: Add GC5035 image sensor driver Nicola Fiorillo
2026-10-09 9:48 ` Laurent Pinchart
2026-10-09 7:27 ` [PATCH 2/3] media: i2c: Add GC8034 " Nicola Fiorillo
2026-10-09 7:27 ` [PATCH 3/3] media: ipu-bridge: Add GalaxyCore GC5035 and GC8034 Nicola Fiorillo
2026-10-09 9:24 ` Dan Scally [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06479beb-4f83-40d0-85c7-a4545e963cbf@ideasonboard.com \
--to=dan.scally@ideasonboard.com \
--cc=hansg@kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicfio@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®