mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Allison Henderson <allison.henderson@oracle.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"liuhangbin@gmail.com" <liuhangbin@gmail.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Vegard Nossum <vegard.nossum@oracle.com>,
	Chuck Lever III <chuck.lever@oracle.com>,
	"shuah@kernel.org" <shuah@kernel.org>,
	"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"horms@kernel.org" <horms@kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"mheyne@amazon.de" <mheyne@amazon.de>
Subject: Re: [PATCH net] selftests: rds: move test.py to TEST_FILES
Date: Tue, 26 Nov 2024 20:04:32 +0000	[thread overview]
Message-ID: <0648385f8654381778b2ceaefe3204d2726f439b.camel@oracle.com> (raw)
In-Reply-To: <20241124073243.847932-1-liuhangbin@gmail.com>

On Sun, 2024-11-24 at 07:32 +0000, Hangbin Liu wrote:
> The test.py should not be run separately. It should be run via run.sh,
> which will do some sanity checks first. Move the test.py from TEST_PROGS
> to TEST_FILES.

This looks fine to me.  Thanks for the catch!
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

> 
> Reported-by: Maximilian Heyne <mheyne@amazon.de>
> Closes: https://lore.kernel.org/netdev/20241122150129.GB18887@dev-dsk-mheyne-1b-55676e6a.eu-west-1.amazon.com
> Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>  tools/testing/selftests/net/rds/Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
> index 1803c39dbacb..612a7219990e 100644
> --- a/tools/testing/selftests/net/rds/Makefile
> +++ b/tools/testing/selftests/net/rds/Makefile
> @@ -3,10 +3,9 @@
>  all:
>  	@echo mk_build_dir="$(shell pwd)" > include.sh
>  
> -TEST_PROGS := run.sh \
> -	test.py
> +TEST_PROGS := run.sh
>  
> -TEST_FILES := include.sh
> +TEST_FILES := include.sh test.py
>  
>  EXTRA_CLEAN := /tmp/rds_logs include.sh
>  


  reply	other threads:[~2024-11-26 20:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24  7:32 Hangbin Liu
2024-11-26 20:04 ` Allison Henderson [this message]
2024-11-28  9:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0648385f8654381778b2ceaefe3204d2726f439b.camel@oracle.com \
    --to=allison.henderson@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=mheyne@amazon.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rds-devel@oss.oracle.com \
    --cc=shuah@kernel.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®