From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1609F2D5A01 for ; Fri, 5 Jun 2026 13:09:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780664967; cv=none; b=UuSNhCMC/MVNMbw8q1TM/aRzJqc9UZp9yV/hCQ7jLolDdN/wVFYPlmnJpOA1JjRTOWzqCQYI5IIscolS7sq7na/oBmnSgt1d6Af8py0teCGsE+FZzgkeHvsxP45SGiUA+T6ANLnvi/CgOsda2in2LRO5LTfpzB7WpNeWOOJzs1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780664967; c=relaxed/simple; bh=g+lhHV8N+B4fb9WldoM+q7EXyp846pVUNO0FPx79itw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=i61zuFHERTGqP2WKu7fgz3W2oIKoQq/LZnWu/3WI+9qIE3z3oRj738xHz5W1XUmZzYxlnwsXTz3N9WSphD3oPfX7rVtt3p4iQ87n1s3tmdOMG7wK6Dr3clH7qeHFM89E5UMgl6r4MFgetdN8y8HLD1pb0QUFLgyAObJDHOq71Iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gxFsZSWD; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gxFsZSWD" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490b4a8e28bso15868945e9.1 for ; Fri, 05 Jun 2026 06:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780664959; x=1781269759; darn=vger.kernel.org; h=content-transfer-encoding:organization:autocrypt:in-reply-to :content-language:references:cc:to:reply-to:subject:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=RWwic0XMe+s8tgCpCjfW/lHyoR3ERWBmi/iK7F/Oi/w=; b=gxFsZSWDTHkV8+n82gJjEFSvLeI7sS/2a6WGHh6kr/z0y+7akpxJjYr5jRZ9JiUe5c IERmkCxhop/emogyk/nI+YNs82LIUAT1rsLbc7t2BH3qoQZ07mKZJ1irfSJNed74+lRD 5qDvsmAYOFmYIhlde3zGfaOrJyG0BdG/ZwS+5KDlnwGvKZzoPYo/v64ywqaWwtAB3kxW y4L48Rm5Z6yAdyxTFlF4R5DXHajNdQdQkfeQLmPNJnExzGjPfRadofx05e1tZxa+UPho 5CkNku9fqDilXsvCm3CCKR6Z8NYNdmB2yafJ9uVAM2kSsDIY11I0V4vLI+ATmXr0vZrg L1jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780664959; x=1781269759; h=content-transfer-encoding:organization:autocrypt:in-reply-to :content-language:references:cc:to:reply-to:subject:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RWwic0XMe+s8tgCpCjfW/lHyoR3ERWBmi/iK7F/Oi/w=; b=D0W/ER4BdY8vlQUVfkMkHM7C9nUbYudC7HEwN8Lh/4IrRkTel+/H42yfODpETUUx+4 +ab4qWY2AprPoT3j5L2tL6HOYQQb+SwoiMr/4bTQHXiVrnwtRDynwXzcgAU/MxphgZf+ Mhe6xIbC/hO+d+6YxaWUNwbsLyV2AzBxMtpJ47x16YzOUYucF26bK+yE6o0F7ExMPklk aes4H5WXN3WdiqQyX/NBieZiHGj6710yztJ4PgotBLte/rtd4hGvAJxo5+UtE95XD1o6 JVGIxcz63KmS4T+T0U3uwoJiTcBkoBWk6KHH8h5H3H6MAY3zFt4W/rroUMi4z6ZDrtEN cLcQ== X-Forwarded-Encrypted: i=1; AFNElJ85llYrdM/4/D8PdLcnCfaNUpVWY2sJAsr8gCxg4Dwypqf4cq56A75CiJjW73IEmBbnfg7MOTDyHKGGVqw=@vger.kernel.org X-Gm-Message-State: AOJu0YxtMSly6j2RN50KRPTupgYSUFnHaO3YsimSPd5IzzgyKcHlxpnv QVCqfAfSAEXmJo4JfbHd8LGYUEB52Q8fk/0bRn2ckNI2tdhYf+jUcyPCesRFiEGuT2g= X-Gm-Gg: Acq92OFMApBY1KN9UqPyqtXhYKYxVsQ1PBGkQKG8m5wfyzhvM8koDDaLCOaQCRWfgJD XPCiYHIxxZXNTo2pFzuKLtMoXODAR2C3TYN00RnZIgOjPCw7BIBuCtTY9WRtYMqo36cvpl+7rrs qsqrwO7pytUWWmq8lxgxp8IhnNOkPJ2B3qh61qAsMJzPaAq4Gz1C1fAjYWBrQSr1PPqYGyZMZl3 lAV5g3i73MrPn99ZVlM52ngh6/3cgPsOzPOQm11kjRS6A2I+7cs3utXoffw2UsDl5QS2hgv5Rh8 ATcFjodlv8gh2on6BMwVrqBuYi7f+UQWPT+4qbBZM7XZ9oJcamMWnvMnAHKkDi68NG/mELzmE3X qu+xDGwXIX2Lv8MEWeUYTYaVJlOqebjNUWDRv49Sqgypnmu5d+xwdjag4S2gEKrnR2ZFtOJ7sIk O9t1BV0H7K4AyE2suUAw8LT8f98onhLQUI331IFZB7lh9q2xyRQpa+JIvTbXVJjvTT0d5T5fljw MJWLCXHW4SG7A0S0w== X-Received: by 2002:a05:600c:190b:b0:490:be9e:fd03 with SMTP id 5b1f17b1804b1-490c2589a02mr53379745e9.7.1780664959143; Fri, 05 Jun 2026 06:09:19 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:b06c:5480:fdc5:c668? ([2a01:e0a:106d:1080:b06c:5480:fdc5:c668]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2f67c6sm25764494f8f.16.2026.06.05.06.09.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 06:09:18 -0700 (PDT) Message-ID: <06489359-1b96-43ad-a065-bfb9bee51a10@linaro.org> Date: Fri, 5 Jun 2026 15:09:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 1/6] drm/msm/a6xx: Fix stale rpmh votes after suspend Reply-To: Neil Armstrong To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Puranam V G Tejaswi , Jie Zhang , =?UTF-8?Q?Ma=C3=ADra_Canal?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shivam Rawat References: <20260605-assorted-fixes-june-v1-0-2caa04f7287c@oss.qualcomm.com> <20260605-assorted-fixes-june-v1-1-2caa04f7287c@oss.qualcomm.com> Content-Language: en-US, fr In-Reply-To: <20260605-assorted-fixes-june-v1-1-2caa04f7287c@oss.qualcomm.com> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/4/26 22:08, Akhil P Oommen wrote: > From: Shivam Rawat > > There are stale RPMH votes (BCM votes) observed after GMU suspend. This > is because the rpmh stop sequences are skipped during gmu suspend. Fix > this and also move GMU to reset state to avoid any further activity. > > Fixes: f248d5d5159a ("drm/msm/a6xx: Fix PDC sleep sequence") > Signed-off-by: Shivam Rawat > Signed-off-by: Akhil P Oommen > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > index 2e5d7b53a0c3..a2f6918c4f7f 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -642,7 +642,7 @@ static void a6xx_rpmh_stop(struct a6xx_gmu *gmu) > int ret; > u32 val; > > - if (test_and_clear_bit(GMU_STATUS_FW_START, &gmu->status)) > + if (!test_and_clear_bit(GMU_STATUS_FW_START, &gmu->status)) > return; > > if (adreno_is_a840(adreno_gpu)) > @@ -1465,6 +1465,9 @@ static void a6xx_gmu_shutdown(struct a6xx_gmu *gmu) > /* Stop the interrupts and mask the hardware */ > a6xx_gmu_irq_disable(gmu); > > + /* Halt the gmu cm3 core */ > + gmu_write(gmu, REG_A6XX_GMU_CM3_SYSRESET, 1); > + > /* Tell RPMh to power off the GPU */ > a6xx_rpmh_stop(gmu); > > Thanks ! Tested-by: Neil Armstrong # on SM8650-HDK