From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbdG1OGr (ORCPT ); Fri, 28 Jul 2017 10:06:47 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37073 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751933AbdG1OGq (ORCPT ); Fri, 28 Jul 2017 10:06:46 -0400 Subject: Re: [PATCH v1 3/6] ASoC: codecs: msm8916-wcd-analog: move codec reset to probe To: Mark Brown Cc: Banajit Goswami , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Patrick Lai , linux-kernel@vger.kernel.org References: <20170726003512.18965-1-srinivas.kandagatla@linaro.org> <20170726003512.18965-4-srinivas.kandagatla@linaro.org> <20170728134013.vsneppa35kra77ot@sirena.org.uk> From: Srinivas Kandagatla Message-ID: <064a5aa7-0a87-7e7b-f263-c24cf66f459a@linaro.org> Date: Fri, 28 Jul 2017 15:06:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170728134013.vsneppa35kra77ot@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/17 14:40, Mark Brown wrote: > On Wed, Jul 26, 2017 at 02:35:09AM +0200, srinivas.kandagatla@linaro.org wrote: >> From: Srinivas Kandagatla >> >> This patch move the codec reset code from dai ops to codec probe, so >> that the codec is not held in reset when headset detection block is >> still active. > > This means that the CODEC will no longer be held in reset (which > presumably has a power benefit or something) even if jack detection > isn't in use. What most devices do is have things like this be > controlled via the bias level or other power management functions and > then have jack detection hold the CODEC out of the lowest power states > when it's active. This chip has two power sources for MBHC logic, one from mic bias which is used when we have active audio usecase, and other from internal current source which is for low-power state when no audio use case is active. By default with the existing code uses internal current source which puts chip in low power state. >