From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794920807; b=2+RJfdUvPvwoy6T/pXRRfvXgnvcWtXCJgcCO7OdfCBYRQhUNGdGyduymCjwEHeDoBQ0x azpgx3FcSAOSseOiElx+l4wNWoTDMNHrrzRlzOME75Z/0IDU0VVZXQXVIyFE50lekadrf vOYmweyl7wP6oRD0ZPtrKW8R6OsKtW+JGQ4eCLbFv4fahgyyDc4NmFD2IGLTekHQEyIQK 54p8Ph0B05h9wuLSOsU60QPVyTZk6lXiDoEQtbdDT1JlXfQn6Mc8WdpMtJ+c0J6GpL+Zm fWEU+vizcgtCbOPfKAV15QTTz/GDVQGZtTbAsadwFdw+dOa8EzP7/PvPGKfTjXYOKPw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794920807; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:Autocrypt: In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Spamd-Result: X-Spam-Score:X-Spam-Level:X-Spam-Flag; bh=7irJd6uHN/H2TpC4FSVWo8zHdZF2tLYaoAHf1ts7pqo=; b=KI5fLpvEunMDIUusT+a81oXS11IhA2pFtvRX3k9d4tLG7uYLHuT32uvWSDTioECB0ZAs oMrMLSeWvpfROJdwlrs6HbOuZmf534iWpQoXtWyGJIponTK28QjASBaxfIo6YokxMEhFf s1XGGi+510x0MQR1JyViACFrfbjNLgdCChaZHfmXXcwniMedW5DERRMfbriFVuD1GEGHL 9YgyARi57zBzkGMc8yxQR2zF+rbf6zy3TOh4GmIukrsfalbTwodAlxOK1CCScwEiI0tlQ W5UabgfHR/lHemqiPMnQaZvMk/qTt3LEtqiewOUBDxtftDrYUhS70eBrNLsHVTQlVnw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AMHzP9Ek; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YKWB32qW; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SkeVBx7n; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mDPkmrpF; arc=none smtp.remote-ip=195.135.223.131 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14B40606A33F for ; Tue, 17 Nov 2026 13:06:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 14B40606A33F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AMHzP9Ek; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YKWB32qW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SkeVBx7n; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mDPkmrpF Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4191E1F747; Tue, 17 Nov 2026 13:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794920804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7irJd6uHN/H2TpC4FSVWo8zHdZF2tLYaoAHf1ts7pqo=; b=AMHzP9EkKzp02qKx84PIJC1WFjFuHv4klcHrIYgjxcs76zSAuRWMknh1QtjcjGO4KhEA6H a91Hz7ixDgCOds47BP/MVL2GSZSWjlzdtg+hFhgNHz0esnGNPeT3bqglPrFMV2c/WDbw+9 DFX9zJD9iEFbZyMMRadHdwjZRMJFXn4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794920804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7irJd6uHN/H2TpC4FSVWo8zHdZF2tLYaoAHf1ts7pqo=; b=YKWB32qWJVToX7DEL4kQFfWKcYTYa9wtVXkMfFwxvOqJTObBpiN9tT0rFU0AY0KjQnd7t+ og6w673nU9na4YBQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794920803; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7irJd6uHN/H2TpC4FSVWo8zHdZF2tLYaoAHf1ts7pqo=; b=SkeVBx7nTdA7rQtMb6IUIhl5PuyY62TkpHKyM2RpCJXWj/gfasqx3Rlz1y9Ghi2yJVbnvT ToeGwsjVWa8LcpYaCa8CIpoHxRlEHmKDfg1FI+vlr04GuAXcCHh6jjE+tQ+LNp6XwrK2wx TuJ+u88F2dtmLs4ekf3J5au3sbI0LLc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794920803; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7irJd6uHN/H2TpC4FSVWo8zHdZF2tLYaoAHf1ts7pqo=; b=mDPkmrpF60O6KeR/YU26ZLRT1uuY3sXS/BKPZVYqyT+Kzfuyj1z0J7AuF7esPGwgKU+5Ml k083zInL/P7AAlAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D3DAC1334C; Tue, 17 Nov 2026 13:06:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Mbp1IWJR/Gq2ZQAAD6G6ig (envelope-from ); Tue, 17 Nov 2026 13:06:42 +0000 Message-ID: <065124a2-d042-4b50-b9f1-3f6c648937b5@suse.de> Date: Tue, 17 Nov 2026 14:06:42 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/simpledrm: Use vblank timer To: Christian , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , =?UTF-8?Q?Michel_D=C3=A4nzer?= Cc: David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-13.29 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; FREEMAIL_TO(0.00)[gmail.com,redhat.com,linux.intel.com,kernel.org,daenzer.net]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[9]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,ffwll.ch,lists.freedesktop.org,vger.kernel.org]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; URIBL_BLOCKED(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo] X-Spam-Score: -13.29 X-Spam-Level: X-Spam-Flag: NO (cc Michel) Hi Am 17.11.26 um 10:49 schrieb Christian: > simpledrm has no vblank interrupt, so DRM_IOCTL_WAIT_VBLANK fails and > Xorg's modesetting driver falls back to a fake vblank of about 1 Hz for > Present. Every client that syncs to vblank on top of it (glxgears, mpv, > Chromium with its default GPU vsync) is paced at roughly one frame a > second. > > Use the DRM vblank timer, as bochs and cirrus-qemu do, so vblank events > come at the rate of the display mode (60 Hz for sysfb modes). We have been discussing general vblank support before; so far with no clear results. Originally the WAIT_VBLANK ioctl and similar functionality is meant to return real hardware values. Using vblank timers for virtual hardware is already a huge exception.  That is still the status quo AFAIU. Why can this problem not be fixed in Xorg? Best regards Thomas > > Measured on an HP ElitePad 900 G1 (Atom Z2760, simpledrm on the EFI > framebuffer, Xorg modesetting + glamor, kernel 7.3.4): glxgears with > vsync went from 1.4 FPS to 24 FPS; Chromium 150 (ANGLE on GLES) > animating CSS from 1.9 to 13.8 FPS, with the GPU process no longer > idling between frames. > > Signed-off-by: Christian > --- > drivers/gpu/drm/sysfb/simpledrm.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/sysfb/simpledrm.c > b/drivers/gpu/drm/sysfb/simpledrm.c > index deaeb7d1f..3461a0f98 100644 > --- a/drivers/gpu/drm/sysfb/simpledrm.c > +++ b/drivers/gpu/drm/sysfb/simpledrm.c > @@ -31,6 +31,8 @@ > #include > #include > #include > +#include > +#include > > #include "drm_sysfb_helper.h" > > @@ -583,10 +585,12 @@ static const struct drm_plane_funcs > simpledrm_primary_plane_funcs = { > > static const struct drm_crtc_helper_funcs simpledrm_crtc_helper_funcs = { > DRM_SYSFB_CRTC_HELPER_FUNCS, > + DRM_CRTC_HELPER_VBLANK_FUNCS, > }; > > static const struct drm_crtc_funcs simpledrm_crtc_funcs = { > DRM_SYSFB_CRTC_FUNCS, > + DRM_CRTC_VBLANK_TIMER_FUNCS, > .destroy = drm_crtc_cleanup, > }; > > @@ -874,6 +878,10 @@ static struct simpledrm_device > *simpledrm_device_create(struct drm_driver *drv, > if (ret) > return ERR_PTR(ret); > > + ret = drm_vblank_init(dev, 1); > + if (ret) > + return ERR_PTR(ret); > + > drm_mode_config_reset(dev); > > return sdev; -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)