From: Johannes Berg <johannes@sipsolutions.net>
To: Peng Zhang <zhangpeng362@huawei.com>,
linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Cc: richard@nod.at, anton.ivanov@cambridgegreys.com,
willy@infradead.org, josef@toxicpanda.com, brauner@kernel.org,
zhangxiaoxu5@huawei.com, wanghai38@huawei.com
Subject: Re: [PATCH] hostfs: Fix the NULL vs IS_ERR() bug for __filemap_get_folio()
Date: Fri, 08 Nov 2024 10:17:24 +0100 [thread overview]
Message-ID: <065b0d76aeea7d3543d3eab302167af039e8f913.camel@sipsolutions.net> (raw)
In-Reply-To: <20241104123440.1347175-1-zhangpeng362@huawei.com>
On Mon, 2024-11-04 at 20:34 +0800, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@huawei.com>
>
> The __filemap_get_folio() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.
>
> Fixes: 1da86618bdce ("fs: Convert aops->write_begin to take a folio")
> Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
Not sure it's critical, but for um I wasn't planning to send a pull
request for 6.12-rc (and I suspect Richard also wasn't, as there are no
other fixes). Also, the original commit went through another tree.
Christian what do you think? Do you want to pick it up? Or should we
pick it up via um, but then likely only for 6.13?
If you could pick it up:
Acked-by: Johannes Berg <johannes@sipsolutions.net>
johannes
prev parent reply other threads:[~2024-11-08 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 12:34 Peng Zhang
2024-11-08 9:17 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=065b0d76aeea7d3543d3eab302167af039e8f913.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=brauner@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=wanghai38@huawei.com \
--cc=willy@infradead.org \
--cc=zhangpeng362@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®