From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932764AbdJaSmq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Oct 2017 14:42:46 -0400
Received: from mail-io0-f196.google.com ([209.85.223.196]:46327 "EHLO
        mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932690AbdJaSmm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Oct 2017 14:42:42 -0400
X-Google-Smtp-Source: ABhQp+RtgaVP2r0YHKH4gUWRG4nAZM6E+6pHRwxiId40gmzsoPbvDdEZK6D7hbyISZcVhw90MO91fQ==
Subject: Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS
To: Will Deacon <will.deacon@arm.com>, Kees Cook <keescook@chromium.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
        LKML <linux-kernel@vger.kernel.org>, kevin.brodsky@arm.com,
        Ingo Molnar <mingo@kernel.org>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        James Morse <james.morse@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Dave Martin <Dave.Martin@arm.com>, credmonster@gmail.com,
        zijun_hu <zijun_hu@htc.com>, Mark Rutland <mark.rutland@arm.com>,
        Jisheng Zhang <jszhang@marvell.com>, Laura Abbott <labbott@redhat.com>,
        John Stultz <john.stultz@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        AKASHI Takahiro <takahiro.akashi@linaro.org>,
        Michal Marek <mmarek@suse.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20170911152635.95367-1-salyzyn@android.com>
 <CAGXu5jK-i_Eqfm1mZ-Kz5dqsKuCt_-MDymkb735VXCV9aOnvwQ@mail.gmail.com>
 <20170920091555.GA3782@arm.com>
From: Mark Salyzyn <salyzyn@android.com>
Message-ID: <065fd365-4635-ddc7-b683-59a5cb16be8f@android.com>
Date: Tue, 31 Oct 2017 11:42:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20170920091555.GA3782@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/20/2017 02:15 AM, Will Deacon wrote:
> On Tue, Sep 19, 2017 at 03:02:22PM -0700, Kees Cook wrote:
>> On Mon, Sep 11, 2017 at 8:26 AM, Mark Salyzyn <salyzyn@android.com> wrote:
>>> Make it possible to disable the kuser helpers by adding a KUSER_HELPERS
>>> config option (enabled by default). When disabled, all kuser
>>> helpers-related code is removed from the kernel and no mapping is done
>>> at the fixed high address (0xffff0000); any attempt to use a kuser
>>> helper from a 32-bit process will result in a segfault.
>>>
>>> Signed-off-by: Mark Salyzyn <salyzyn@android.com>
>>>
>>> v2:
>>> - vectors_page and compat_vdso_spec as array of 2
>>> - free sigpage if vectors allocation failed
>>> - adjust makefile so one line for each of the assembler source modules
>>> - split off assembler changes to a new previous patch in series to reduce churn
>>> - modify slightly the feature documentation to reduce its reach
>>> - modify slightly the feature documentation to rationalize the yes default.
>>> - There are more ifdefs as a result of the rebase.
>>>
>>> v3:
>>> - rebase (minor conflicts)
>> This looks great to me. I'd love to see kuser helpers gone. :)
>>
>> Catalin, Will, does this need anything else?
> I haven't had chance to look at the patches yet (buried in other stuff), but
> I aim to get to it in the next couple of weeks.
>
> Will

Ping?