From: Astrid Rost <astridr@axis.com>
To: Rob Herring <robh@kernel.org>, Astrid Rost <astrid.rost@axis.com>
Cc: Dan Murphy <dmurphy@ti.com>, Andrew Davis <afd@ti.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <kernel@axis.com>,
<linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] dt: bindings: lp50xx: Add max-brightness as in leds-pwm
Date: Fri, 30 Jun 2023 09:23:33 +0200 [thread overview]
Message-ID: <065fe185-4004-2329-f016-bb5161266094@axis.com> (raw)
In-Reply-To: <20230629175939.GA3260807-robh@kernel.org>
On 6/29/23 19:59, Rob Herring wrote:
> On Thu, Jun 29, 2023 at 03:47:22PM +0200, Astrid Rost wrote:
>> Add max-brightness in order to reduce the current on the connected LEDs.
>> Normally, the maximum brightness is determined by the hardware, and this
>> property is not required. This property is used to set a software limit.
>> It could happen that an LED is made so bright that it gets damaged or
>> causes damage due to restrictions in a specific system, such as mounting
>> conditions.
>>
>> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
>> ---
>> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> index 402c25424525..6a1425969cb4 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> @@ -73,6 +73,15 @@ patternProperties:
>> '#size-cells':
>> const: 0
>>
>> + max-brightness:
>> + description:
>> + Normally, the maximum brightness is determined by the hardware, and
>> + this property is not required. This property is used to set a software
>> + limit. It could happen that an LED is made so bright that it gets
>> + damaged or causes damage due to restrictions in a specific system,
>> + such as mounting conditions.
>> + $ref: /schemas/types.yaml#definitions/uint32
>
> We already have led-max-microamp. If this h/w works by controlling the
> current, then that is what you should use. "max-brightness" makes more
> sense for PWM based control.
Yes, I looked into this. This LED controller TI-LP5024 has only one flag
as max current option, which allows to set between 35 mA and the default
value 25.5 mA. This is not enough for our application.
>
> If you do end up keeping this, it belongs in the 'led' nodes not the
> controller as brightness is a property of the LED, not the LED
> driver(controller). And it should be in common schema rather than
> defining the type yet again.
I will look moving it into the the LED generic bindings as Andy
suggested. max_brightness is already there and handled correctly. It is
just a matter of reading it from the devicetree.
>
> Rob
prev parent reply other threads:[~2023-06-30 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230629134722.3908637-1-astrid.rost@axis.com>
2023-06-29 13:47 ` [PATCH v1 1/2] led: leds-lp50xx: " Astrid Rost
2023-06-29 13:55 ` Andy Shevchenko
2023-06-29 13:47 ` [PATCH v1 2/2] dt: bindings: lp50xx: " Astrid Rost
2023-06-29 17:59 ` Rob Herring
2023-06-30 7:23 ` Astrid Rost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=065fe185-4004-2329-f016-bb5161266094@axis.com \
--to=astridr@axis.com \
--cc=afd@ti.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=astrid.rost@axis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®