From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FD2D309DA5 for ; Mon, 5 Jan 2026 17:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767635649; cv=none; b=KEUljfI2ltygU++KuOtNtPozQQtPubvc1OdxkM4OMSyvAT52UJEC2Eb240NLXwHoyYJfJynYnAezMOHHuLjr3u2/YskRU+6AIV+IrJb7CbB4rv3dWcLJ1+De5h6iopa315GCcJVwVkzUdNfm2F0vXlWW+uF8GgAbHMJs7jwP9F4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767635649; c=relaxed/simple; bh=udwWkdhpTzT2eQUkwfGyGq8r6Ut5AbsbTRHIFrQ1B/0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Sew8lC/WpGhSvVwlemYAfhAxBhLODm6+0pcKfZtWxrOmraqoXK+pajZtghl7r+Z0ZqilaxvQMSgz+/SZbQ/DXJTOvEOyHhFSm9NH4sNcL636FEuASq4f4Rx4q8q26cW12ZDo/GngjtfeRTv/QSrzk+VWYF/NjfItgtN7yFeW7CU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NqCFXncl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d7xIdfqy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NqCFXncl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d7xIdfqy" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 605GOLOr1918680 for ; Mon, 5 Jan 2026 17:54:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= up2RJ7mBO3QRQNqNSX63k2cfkFf65kx0CXGDWq797Cw=; b=NqCFXncl0eE41y7F 1cjWzK7v1HtXjtW0mU7ToSsxoWtRLv7c7lswLOrH4GN//cBpvicmRjLDoMWRV9SZ oJ7HiiI9szam6Biqz/qlgvPCvu+FNz56ehYrUtMn2stq4V4ME496IQqEmbSCON5l 02S2WYsLDMqnv7VnK7IQW+BwGzG+ubNQYTRKCUpiUjIroRnDLeP0ysbL0SQ6xNGW jpNpXpjDUXUjSL68EzqN6d3mKrEJvEsMpGTU6v1dXQ6Dql5Rfz71JbrsxuXo56ut iwF9wHgJiZhZS4aNKntm2AKN64SUTrVRnX0stKs6bXYKgu1p2ljx5Gh3YaocQGyt bx/xKA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bggsvr83v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 05 Jan 2026 17:54:06 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-34cc8bf226cso717157a91.3 for ; Mon, 05 Jan 2026 09:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767635645; x=1768240445; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=up2RJ7mBO3QRQNqNSX63k2cfkFf65kx0CXGDWq797Cw=; b=d7xIdfqy+Wgt0ltzP0mFBL2TKXaT5RBxqRfSmreAk937tYHkRgfSdUaC7uPbZy21qO QO584bKN+k2ERhLvRsJS+x68gIH2HBRVJMaJvmFHQKz/74jOgkQJpNsLxhQj1zkEOYbk Xusqi+NrW0JZ6x3q8fnMyjvzGWtMrVIZnT23d2WNz+ARZW/swP1cpImY5mZZ9VbuH5KK JEJoXeskeca5UaDa07swuBSODM//s04gzNfEouMFKGDYIf6wtR/u98h6tEpaWpHt1EkL 4ulM3fn9nghdCR51zBWQLlHEDlJSTLQPoSPQpxDiVN0U/ccggv7SCTVRJemhjJbvGkbS /Ykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767635645; x=1768240445; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=up2RJ7mBO3QRQNqNSX63k2cfkFf65kx0CXGDWq797Cw=; b=RJwDJJmiCPyYb2n9YEvgi9bzESU2g4rJLDeYdp0nKbdAhdAKunc0yR+qJ4vSlRsjRR yupBvYdKQOZxwLYu8WygA59AQoX7j0w4LA161Wuhn+F3PDVjbo/FgLv0EGuz7mjI7cbV D34KloQGkeypcPlO8rJ090NbBq171uQiz4mugQgDcqeHwZrV/ebO1HmW42kvKzIs/hzL V7sRYvfOjNfLpmRopSSDF3xGoct6MfQyl0aZUIe2V7Ih5GHNAGzGyAl/UqLqlo0T4+II 1My2shfmmY06wjMiatXtxrYtb2Y4KjCGsEFDf0dPKvqT/EFWIgO30CI70A3w1wrcgbQi bO8A== X-Forwarded-Encrypted: i=1; AJvYcCXxRrtgbYj6LjrradqgxfcMZ4XbCv4jX8ywcTGQv/9lGw1NgPxEwTGHYRrVOwb6Bo0XFqn7/hkKht4PGWg=@vger.kernel.org X-Gm-Message-State: AOJu0YzPVsRp1idAv3ViVFSfYwHC+hFjjT1WcHHQBruldji1u0V3wnIy 90Ron6Ro7K4jlP6JdKmOhvaj0b7nykGBYqTTGydMnxufd9p/fKQ6M7Ef03K1Bym2CcxRgeqCWnQ BEFMQJWM7dCSf4Ul7QP0n1iISl6JKmZKGz7Ognb+iuSMHuQOD48ThhRmUslMZX14EBP0= X-Gm-Gg: AY/fxX6sYB+7R5FSPr1Z+JWrXucZDfjW+XummFrFsYv/Te86k2kqtc+pe4jkGKRTtM9 j7ko00VxDQrvkaHEOa9l0JptNXkKFl4gFLIOOBBetpJrTUuoXIDzvPftdNJ+H26etKc604hyCBi YL2lUhd8K3E2KcUlgYy6FwfA3vWxF/WgJ3L6KWwDTFTRIt4/vJUyhSmm/Y/yaOKC+c41eh/PPT3 nzQL+9rAICcgqFiKQe0rc1WhMpjjK0IiBHMWfhGxZ4rwTfvQhQ8+ToiSUTNluEif0/hM9cVhOFS Gumg3ySSHpUNWJ/0RZcvlXMzRNfv2NO6Ht59PTk3un8N6dImOlkjQ9WEHl+boZWy80CAPoP803B YzWImoRxZtDpoMk7W5lRThCMRVQAkVTptLDVcea9d627obyC+cVz5KhDUHg3QvX6gpDdTYe+eCW mtnICp X-Received: by 2002:a17:90b:2684:b0:34a:b8e0:dd64 with SMTP id 98e67ed59e1d1-34f5f273b91mr120673a91.1.1767635645298; Mon, 05 Jan 2026 09:54:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEAjGO3oXRkqFt+Dr912mQRBhrraJgw+/RX85ptzw8Hrud60zSlNKtqDujFJK5kumkbSyRog== X-Received: by 2002:a17:90b:2684:b0:34a:b8e0:dd64 with SMTP id 98e67ed59e1d1-34f5f273b91mr120641a91.1.1767635644778; Mon, 05 Jan 2026 09:54:04 -0800 (PST) Received: from ?IPV6:2405:201:c408:b07b:6589:c739:d9cc:4910? ([2405:201:c408:b07b:6589:c739:d9cc:4910]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5f7a557asm11725a91.3.2026.01.05.09.53.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 09:54:04 -0800 (PST) Message-ID: <06619e53-7260-7bd2-1954-dd10b92dc354@oss.qualcomm.com> Date: Mon, 5 Jan 2026 23:23:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v19 01/10] power: reset: reboot-mode: Remove devres based allocations Content-Language: en-US To: Bartosz Golaszewski Cc: Lorenzo Pieralisi , Arnd Bergmann , Bjorn Andersson , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Andy Yan , John Stultz , Matthias Brugger , Moritz Fischer , Mark Rutland , Conor Dooley , Konrad Dybcio , Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Kathiravan Thirumoorthy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Srinivas Kandagatla References: <20251228-arm-psci-system_reset2-vendor-reboots-v19-0-ebb956053098@oss.qualcomm.com> <20251228-arm-psci-system_reset2-vendor-reboots-v19-1-ebb956053098@oss.qualcomm.com> From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: mrNBAzldDsfZ0T4tdhZMOBu7RpTNTgvn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDE1NCBTYWx0ZWRfXymClEn/rTksc l4rkpw6Z1+wlk5XeKYzzCOUm24F3+AkNQpgHqtgey1zb/c/PaOUOSfwiXwLfieDnjhbg6SMva0P 19fiDrVSIBpFIkxPWvDgb8ZtSZMgJ66pHjCV4jo4BSqd6wh1ESwv5okcEhjJzU2s3l0P/B1UeVe MGPX1oxtVbK7KGY9MZhzlZ5MXhnWRE8PR+AWmmI+f3EOMXWr/XDrHxtz1Zb6/Eh9sgewj5rWi5k Tee9EpekPY2y77fBnWKly+1eZ5jF6bvtaCSsYVrECbDBLdlZwX1kcPy0eQiPU3jC+6pr8syeu7b oeFjfSCG3Vx5UEGpKrIAzF3A4g14CQDU5ICaOpoY+569eEaHLyEy4rP9yAI2XGcv7JRTXo8dLe8 PoWuzBYEyUQGx3oMrDspNkSvmsW0GzjRCxs+PI+9sMNf3Ip6KxhPaIs+FVKdH39Te+uvLhy0XMJ jx7NrQmTIiq6nm8yQmQ== X-Proofpoint-ORIG-GUID: mrNBAzldDsfZ0T4tdhZMOBu7RpTNTgvn X-Authority-Analysis: v=2.4 cv=Yv4ChoYX c=1 sm=1 tr=0 ts=695bfabe cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=LC1Hwnd0PhZBVGXlRGcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 spamscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601050154 On 1/2/2026 3:35 PM, Bartosz Golaszewski wrote: > On Sun, Dec 28, 2025 at 6:20 PM Shivendra Pratap > wrote: >> >> Devres APIs are intended for use in drivers, where the managed lifetime >> of resources is tied directly to the driver attach/detach cycle. In >> shared subsystem code, there is no guarantee that the subsystem >> functions will only be called after a driver has been attached, nor that >> they will not be referenced after the managed resources have been >> released during driver detach. [SNIP..] >> >> @@ -71,9 +74,11 @@ static int reboot_mode_notify(struct notifier_block *this, >> int reboot_mode_register(struct reboot_mode_driver *reboot) >> { >> struct mode_info *info; >> + struct mode_info *next; >> struct property *prop; >> struct device_node *np = reboot->dev->of_node; >> size_t len = strlen(PREFIX); >> + u32 magic; >> int ret; >> >> INIT_LIST_HEAD(&reboot->head); >> @@ -82,19 +87,17 @@ int reboot_mode_register(struct reboot_mode_driver *reboot) >> if (strncmp(prop->name, PREFIX, len)) >> continue; >> >> - info = devm_kzalloc(reboot->dev, sizeof(*info), GFP_KERNEL); >> + if (of_property_read_u32(np, prop->name, &magic)) { > > Please use device_property_read_u32() if you have access to a device struct. Ack. Can it go in same patch with the fixes tag? > >> + pr_err("reboot mode %s without magic number\n", prop->name); > > If this is an error, shouldn't we bail out? > >> + continue; >> + } >> + >> + info = kzalloc(sizeof(*info), GFP_KERNEL); >> if (!info) { >> ret = -ENOMEM; >> goto error; >> } >> >> - if (of_property_read_u32(np, prop->name, &info->magic)) { >> - dev_err(reboot->dev, "reboot mode %s without magic number\n", >> - info->mode); >> - devm_kfree(reboot->dev, info); >> - continue; >> - } >> - >> info->mode = kstrdup_const(prop->name + len, GFP_KERNEL); >> if (!info->mode) { >> ret = -ENOMEM; >> @@ -102,8 +105,7 @@ int reboot_mode_register(struct reboot_mode_driver *reboot) >> } else if (info->mode[0] == '\0') { >> kfree_const(info->mode); >> ret = -EINVAL; >> - dev_err(reboot->dev, "invalid mode name(%s): too short!\n", >> - prop->name); >> + pr_err("invalid mode name(%s): too short!\n", prop->name); >> goto error; >> } >> >> @@ -116,8 +118,12 @@ int reboot_mode_register(struct reboot_mode_driver *reboot) >> return 0; >> >> error: >> - list_for_each_entry(info, &reboot->head, list) >> + kfree(info); >> + list_for_each_entry_safe(info, next, &reboot->head, list) { >> + list_del(&info->list); >> kfree_const(info->mode); >> + kfree(info); >> + } >> >> return ret; >> } >> @@ -130,11 +136,15 @@ EXPORT_SYMBOL_GPL(reboot_mode_register); >> int reboot_mode_unregister(struct reboot_mode_driver *reboot) >> { >> struct mode_info *info; >> + struct mode_info *next; >> >> unregister_reboot_notifier(&reboot->reboot_notifier); >> >> - list_for_each_entry(info, &reboot->head, list) >> + list_for_each_entry_safe(info, next, &reboot->head, list) { >> + list_del(&info->list); >> kfree_const(info->mode); >> + kfree(info); >> + } > > The code is repeated here, maybe factor it out into a separate function? Ack. let me try that. thanks, Shivendra