From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751794AbdIOSlf (ORCPT ); Fri, 15 Sep 2017 14:41:35 -0400 Received: from mout.web.de ([212.227.15.14]:62658 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdIOSld (ORCPT ); Fri, 15 Sep 2017 14:41:33 -0400 Subject: [PATCH 1/2] [media] ti-vpe: Delete an error message for a failed memory allocation in two functions From: SF Markus Elfring To: linux-media@vger.kernel.org, Archit Taneja , Benoit Parrot , Mauro Carvalho Chehab Cc: LKML , kernel-janitors@vger.kernel.org References: <8137a759-cbfd-e04d-0adb-06de1b3246d1@users.sourceforge.net> Message-ID: <066c05d5-ca92-2ff9-4b1d-ce21528ae938@users.sourceforge.net> Date: Fri, 15 Sep 2017 20:41:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <8137a759-cbfd-e04d-0adb-06de1b3246d1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:yf8rIR9L/wuSQRUlazPj0BaqrsyEX5M1q0ch1nA6tmfxOPkAnpU tNF3ijQXS2EUwRriqKJP4xEALOrBsFZxO4E1soOZ2NxFue6NX3uATM9QxUskLJ5KlqTkTeU xX4q/iGy/xGBB4CzBoUIEisU/B6YQRkZCpXCPUthD/HVNeIHylvOBQ2X6HD5avY2KIENV+q QHYKqm2QSVyaBuHRGFPbA== X-UI-Out-Filterresults: notjunk:1;V01:K0:XNN/Jl7SR90=:qydIobYfJZ6zKegWJSn/aM MLKSB0RFW2N41Ir9WjJ+q16Xumw2FfJ1s+odDczyuhP9LLRwU2TPZe2Rcsuvx0/DoKVEBXycf umItomxGF/rxhw26xckw41WbVS6xXiYbNeBMA0fv9Ippzpnt7qpuKAeGH6W57Vt7P39W8WKLU OvsnLJTUcmjmvStMD4PDgeruBsD7m8YtdIjAUB5zweCJO6Ke2VZV7EaQBGI2EWqce74qYWbkF Hz7K9VPMnM6xcqRquKfcECaSk6qykIJSCHv4kIVV7RziZOLgP0o3VmK7Do5poAPYGJcmLEhc4 Gi3Ow6Nx/yOSXFTK9aWiNM/bZ8Fpv6PCmB0x9B2/+KvXva9a2IrSFpnAwKcTdJ+a8RXrUdbvX mDJOzxh6daEL6jaO+tECpbglGxiUfP4AUl5wPw0AEAYlPKoX8bhozqgUO20vQpWiwFWj9hR53 y9+C3VDfCuhoW+49a91gYjiMoXFivV8aDvBd7j1G9SNAB3Mr8Jw1bkLLen6PuijO0Lhkp8XtK 7fBl5BjtZ4zo/azOIPWzAbyNAV35d11tXyY+WU6r6V+VEUTvRYl0L7GA8a7ZNU/6+qdcxY1cp +hUWONehEC0kMjQn8DhAn5m2z8GC0l7WqYJrDdqWFmllWQf7Td+67AxXJ5czAF+/DKycRHXv4 5jVoqymSog1jDuTJTWLhsqoGhwP2RnyZ6cWjmD6yTGivYF8WyJk4WHcmcoQTCv5vQT94AS9Q5 OR3S8yIyEN5tdhbvBfpmehmcRjlhSTXxlZd+3KK70EaFjIgpqWzrQ1/z87WkKILpcuACRIvqb xzs/o7je2080JrSQE5ScO1yt9iLTPMWSGvKDWZuWbBs764AYxs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 15 Sep 2017 20:15:17 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/platform/ti-vpe/csc.c | 4 +--- drivers/media/platform/ti-vpe/sc.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c index 44b8465cf101..135fc9993679 100644 --- a/drivers/media/platform/ti-vpe/csc.c +++ b/drivers/media/platform/ti-vpe/csc.c @@ -176,8 +176,6 @@ struct csc_data *csc_create(struct platform_device *pdev, const char *res_name) csc = devm_kzalloc(&pdev->dev, sizeof(*csc), GFP_KERNEL); - if (!csc) { - dev_err(&pdev->dev, "couldn't alloc csc_data\n"); + if (!csc) return ERR_PTR(-ENOMEM); - } csc->pdev = pdev; diff --git a/drivers/media/platform/ti-vpe/sc.c b/drivers/media/platform/ti-vpe/sc.c index e9273b713782..e9e307875feb 100644 --- a/drivers/media/platform/ti-vpe/sc.c +++ b/drivers/media/platform/ti-vpe/sc.c @@ -284,8 +284,6 @@ struct sc_data *sc_create(struct platform_device *pdev, const char *res_name) sc = devm_kzalloc(&pdev->dev, sizeof(*sc), GFP_KERNEL); - if (!sc) { - dev_err(&pdev->dev, "couldn't alloc sc_data\n"); + if (!sc) return ERR_PTR(-ENOMEM); - } sc->pdev = pdev; -- 2.14.1