From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2661734D3B5 for ; Fri, 29 May 2026 01:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780016451; cv=none; b=KFoqX2y2RwEm3JDxJCHxmbd1hLgMRNxx9TavnWSkv4qIPsi00dTioh0bKh19c02yyPYsBFQ9QORLpd+pDuh63wWLpyge9ZlvkBkjZ7/0Uin0xhHupCxZIUzCs/BEENkUMyltsFdn8aeuTXQtB115HrElk3gdbvlonykse2XtLa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780016451; c=relaxed/simple; bh=PBRO3etB7lPkL1yRU0UjynsOCXgaIULKhqql2Fq7OQM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=XbhhUlCgZ48pt1zw9yg90TpDRdjyR4EVqx65WzerQYQ8ZEOaiKAO1kSdBeuWC3DgQ4yhy9nFnSk978AqZ56HY6Q6KWxDtQH4icKGQBeG0+RgfnoTWUSe2jELxAlO5VC6oaqMaIz7zTy9+hpGwVJo6uhMW3yKNRfUOySlO8mBjnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ibY+a0CW; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XfbxniB+; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ibY+a0CW"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XfbxniB+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780016449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PBRO3etB7lPkL1yRU0UjynsOCXgaIULKhqql2Fq7OQM=; b=ibY+a0CWsblI7BryN//b4u1C/4T4uKaYczA58kfO9/MgBZ3hTfofEukdspv2qqeN+wxUfv QS2yg2HIGo6XrZRCgACtC/guuMaIfFBkVPoX2QYJCCPHU4WA+LMi15c9yqkmUAoI6nWunN 7N6P3EVGMltRzGi7c+MCdRtAAvHyMls= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-oZyvYP0-O4uUiNpqc2wAdg-1; Thu, 28 May 2026 21:00:47 -0400 X-MC-Unique: oZyvYP0-O4uUiNpqc2wAdg-1 X-Mimecast-MFC-AGG-ID: oZyvYP0-O4uUiNpqc2wAdg_1780016447 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-516ccfa109dso148027071cf.0 for ; Thu, 28 May 2026 18:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780016447; x=1780621247; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=PBRO3etB7lPkL1yRU0UjynsOCXgaIULKhqql2Fq7OQM=; b=XfbxniB+GWqY7vyErzUyPBQRge8BgDhFVN/kopRWKyFizKcs60qGwTeaXLKKnkVdvo 8/YaBL12msoOk/1CGQf9VOIAKtj+UeYgzUQmHoukUzfMY8kb28ct5cwQ9qi94qwVxABB phG1j8dLt+T0WS8R/s3yDcQNzHJPnk5hY/rwgpgSjsHEx9JfUI5DqCNQOpZmJ1NoCu8y c45cVvmcKuJHDjH2QD4FbUXFgq2m92VgxwAlBpmLbfXIUNPn/3W3tn/zsnY53PW7sB2F 8Rln9vYeXyCQGMYvEtOvr7IR9rAvc8fLE4rWnNwPIqK29SQJbBpzK6Zv8UAPkN1HA1gJ 7suQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780016447; x=1780621247; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PBRO3etB7lPkL1yRU0UjynsOCXgaIULKhqql2Fq7OQM=; b=Gxmng5DDuj6t6kKkxwxuggmINQSCg5poGdTI7oJSW/5KagBKO5UBFntDEgepQCg1cj NDmCSUJpznWB550YfYj6OZ1ZfD+cSHESljXFPXZfKfnllXLD3zbINdpBe5fWj6uqzxDx 8N92xnE6WRnqLlDMDDPbX10eg2CGCUrPb0+VhsmJrchUsBZgBre1TpP8T5PfgMxKr6Nc /Z63ZOKLmntA4rNpHmWNaozsg4+MyXMF34fF6BeSoERIUh0u0ywLeImSiu37y+mYcOyw g7jYLpzVDB/4T2w9K3d40IGBoB1NzU1LIp8mKfDqRtAL7cCSkzg8vKIK3a0pyrFSss8b GCQQ== X-Forwarded-Encrypted: i=1; AFNElJ8B9nvSaPg1IxaZ6fOFt35NBOXkYKIR8NYqSYCjEDn0rMUFHn2OUOROPb1gt51L5P12wkdpTDgZKSl0rhM=@vger.kernel.org X-Gm-Message-State: AOJu0YzWPg/thcAKcfm57kqBf5j503HZ5ZStc5u5kSQb56As8yUOEmDW WVFU2B5fG8LuJWEevcyFzBU/Xgf1jlEEJwxLbN1ZSXNfAjRHQYE7L42p209iIJdNTQdWRpcgYiZ h+2isqH27XCxMm+Dh3YjBsQCFgQIeVNQHdh2Q9U5CzQb6t9wjkfZ/XdLRmwiZv0ZKrQ== X-Gm-Gg: Acq92OFCNZY3CidBecFXw5Mr6RKdPoBcD+7b7oH+IYeyLIUbKaNBpraRXy1gUWUk65v iLPOOMCjvud0/XpZCIMjNyOtK5TSBT7gDeY+Sjz3jjTD9GDql7bVC1wjE15qvz9MMOVvBxQQ1v3 fWibXkNqOhK1gv6eFt/tVx6Tl8vlJhN5yHt4ElEvIMIdrQxL4iBXuqYbj4u0K0nuuDzolfI9Q2v +HHvXQRkZ+HjZd831OVIqBl/4jKlwUeY/OYMJYp/6eJ8MmQgPHgeaV+7FDdQw+cDhUiUATYD78z yxS2avnKcP+FEcPVJD5MunThte5VtynqB6O8PU44C9pkibPVAK5twBMip69hBmGALKw15upk/Bo DXjYgryVuirDebQcvpmY+RFQ4PyAG X-Received: by 2002:a05:622a:1b2a:b0:516:dc50:a01a with SMTP id d75a77b69052e-5172dc1e44dmr12443271cf.5.1780016446556; Thu, 28 May 2026 18:00:46 -0700 (PDT) X-Received: by 2002:a05:622a:1b2a:b0:516:dc50:a01a with SMTP id d75a77b69052e-5172dc1e44dmr12441761cf.5.1780016445788; Thu, 28 May 2026 18:00:45 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5172e9a5034sm5068741cf.6.2026.05.28.18.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 18:00:45 -0700 (PDT) Message-ID: <066ef2f147aa7b568d31983b8ba4427c3eeeaea4.camel@redhat.com> Subject: Re: [PATCH 3/6] rust: drm: Add RegistrationData to drm::Driver From: lyude@redhat.com To: Danilo Krummrich , aliceryhl@google.com, airlied@gmail.com, simona@ffwll.ch, daniel.almeida@collabora.com, acourbot@nvidia.com, apopple@nvidia.com, ecourtney@nvidia.com, deborah.brouwer@collabora.com, ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, tmgross@umich.edu Cc: driver-core@lists.linux.dev, nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Date: Thu, 28 May 2026 21:00:44 -0400 In-Reply-To: References: <20260506221027.858481-1-dakr@kernel.org> <20260506221027.858481-4-dakr@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-05-28 at 20:15 -0400, lyude@redhat.com wrote: > FWIW: now that I've noticed this, that might simplify things w/r/t > what > KMS needs here from DeviceContext and allow me to go from modeling > DeviceContext around 3 stages (Uninit, Initialized, Registered), to > just 2 stages (Initialized, Registered). The purpose of having a > separate Uninit and Initialized had been to workaround not having > access to `drm::Driver::Data` when a driver performs an atomic commit > before userspace registration, which would be a big ergonomic issue > for > implementing a lot of atomic KMS callbacks. >=20 > But if that's not an issue with this patch series, then it probably > makes more sense for me to respin that DeviceContext patch series to > reflect that since that simplifies things a lot for the KMS side. For > your patch series, it just means you have to replace "Uninit" with > "Initialized" in the next version. >=20 > I will send out a respin with this tomorrow after working on > respinning > the gem shmem patch series, since that shouldn't take me very long at > all. Actually - after working on it a little bit more, I think having the 3 states (Uninit, Initialized, Registered) is still going to make sense for KMS. So, I probably actually don't need to respin/change the DeviceContext series from how it is right now after all! Sorry for the noise :)