From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nand: brcmnand: fix OOB R/W with Hamming ECC
Date: Wed, 24 Feb 2021 08:16:58 +0100 [thread overview]
Message-ID: <0670B343-C39E-4610-8061-A7F81F90B9F4@gmail.com> (raw)
In-Reply-To: <32837cb2-f7ba-d59e-de66-051019b21e89@gmail.com>
Hi Florian,
> El 24 feb 2021, a las 4:46, Florian Fainelli <f.fainelli@gmail.com> escribió:
>
>
>
> On 2/22/2021 12:16 PM, Álvaro Fernández Rojas wrote:
>> Hamming ECC doesn't cover the OOB data, so reading or writing OOB shall
>> always be done without ECC enabled.
>> This is a problem when adding JFFS2 cleanmarkers to erased blocks. If JFFS2
>> clenmarkers are added to the OOB with ECC enabled, OOB bytes will be changed
>> from ff ff ff to 00 00 00, reporting incorrect ECC errors.
>>
>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>
> Should there be a Fixes: tag provided here for back porting to stable trees?
I think so, but the fixed commit would be the first one, right?
27c5b17cd1b10564fa36f8f51e4b4b41436ecc32
> --
> Florian
Best regards,
Álvaro.
next prev parent reply other threads:[~2021-02-24 7:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 20:16 Álvaro Fernández Rojas
2021-02-24 3:46 ` Florian Fainelli
2021-02-24 7:16 ` Álvaro Fernández Rojas [this message]
2021-02-24 7:38 ` Miquel Raynal
2021-02-24 8:02 ` [PATCH v2] " Álvaro Fernández Rojas
2021-02-24 21:01 ` Brian Norris
2021-02-25 7:48 ` Miquel Raynal
2021-02-25 7:54 ` Álvaro Fernández Rojas
2021-02-25 8:12 ` Miquel Raynal
2021-03-02 16:32 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0670B343-C39E-4610-8061-A7F81F90B9F4@gmail.com \
--to=noltari@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®