From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753196Ab0I0FZd (ORCPT ); Mon, 27 Sep 2010 01:25:33 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:49579 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751497Ab0I0FZb convert rfc822-to-8bit (ORCPT ); Mon, 27 Sep 2010 01:25:31 -0400 From: "Datta, Shubhrajyoti" To: Vasiliy Kulikov , "kernel-janitors@vger.kernel.org" CC: Dmitry Torokhov , "Chemparathy, Cyril" , Kevin Hilman , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Mon, 27 Sep 2010 10:55:24 +0530 Subject: RE: [PATCH] keyboard: tnetv107x: fix input_device leak Thread-Topic: [PATCH] keyboard: tnetv107x: fix input_device leak Thread-Index: ActdWWPxNBfwT1ICRYaaynFLEKzJCwAqeVTQ Message-ID: <0680EC522D0CC943BC586913CF3768C003FF0594C8@dbde02.ent.ti.com> References: <1285491584-32664-1-git-send-email-segooon@gmail.com> In-Reply-To: <1285491584-32664-1-git-send-email-segooon@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: linux-input-owner@vger.kernel.org [mailto:linux-input- > owner@vger.kernel.org] On Behalf Of Vasiliy Kulikov > Sent: Sunday, September 26, 2010 2:30 PM > To: kernel-janitors@vger.kernel.org > Cc: Dmitry Torokhov; Chemparathy, Cyril; Kevin Hilman; linux- > input@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] keyboard: tnetv107x: fix input_device leak > > keypad_probe() calls input_free_device() on error, but keypad_remove() > doesn't. > --- > Compile tested. > > drivers/input/keyboard/tnetv107x-keypad.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/input/keyboard/tnetv107x-keypad.c > b/drivers/input/keyboard/tnetv107x-keypad.c > index b4a81eb..1ea20e1 100644 > --- a/drivers/input/keyboard/tnetv107x-keypad.c > +++ b/drivers/input/keyboard/tnetv107x-keypad.c > @@ -305,6 +305,7 @@ static int __devexit keypad_remove(struct > platform_device *pdev) > free_irq(kp->irq_press, kp); > free_irq(kp->irq_release, kp); > input_unregister_device(kp->input_dev); > + input_free_device(kp->input_dev); It does not seem to be correct. > clk_put(kp->clk); > iounmap(kp->regs); > release_mem_region(kp->res->start, resource_size(kp->res)); > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html