From: "Nayak, Rajendra" <rnayak@ti.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Juha Keski-Saari <ext-juha.1.keski-saari@nokia.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"Manuel, Lesly Arackal" <leslyam@ti.com>
Subject: RE: [PATCH] regulator: twl-regulator - fix twlreg_set_mode
Date: Tue, 26 Oct 2010 15:40:06 +0530 [thread overview]
Message-ID: <0680EC522D0CC943BC586913CF3768C003FF2DAF9D@dbde02.ent.ti.com> (raw)
In-Reply-To: <1287841635.7486.3.camel@odin>
> -----Original Message-----
> From: Liam Girdwood [mailto:lrg@slimlogic.co.uk]
> Sent: Saturday, October 23, 2010 7:17 PM
> To: Nayak, Rajendra
> Cc: Axel Lin; linux-kernel; Juha Keski-Saari; Mark Brown
> Subject: Re: [PATCH] regulator: twl-regulator - fix twlreg_set_mode
>
> On Fri, 2010-10-22 at 08:30 -0700, Mark Brown wrote:
> > On Fri, Oct 22, 2010 at 04:38:22PM +0800, Axel Lin wrote:
> > > The Singular Message is 16 bits:
> > > DEV_GRP[15:13] MT[12] RES_ID[11:4] RES_STATE[3:0]
> > >
> > > Current implementation return immedially after sucessfuly write MSB part.
> > > To properly set mode, we need to write the complete message ( MSB and LSB ).
> > >
> > > In twl.h, now we have defines for PM Master module register offsets,
> > > use it instead of hard coded 0x15/0x16.
> > >
> > > Use "message & 0xff" to ensure we send correct value for LSB.
> > >
> > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> >
> > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> >
> > > I don't have this hardware handy, I appreciate if someone who has the
> > > hardware can test this patch.
> >
> > I beleive Liam has appropriate hardware.
>
> Rejendra, care to test this ?
Sure, either me or Lesly will test this on one of the twl4030 based platforms
and update.
>
> Thanks
>
> Liam
> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-10-26 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 8:38 Axel Lin
2010-10-22 15:30 ` Mark Brown
2010-10-23 13:47 ` Liam Girdwood
2010-10-26 10:10 ` Nayak, Rajendra [this message]
2010-11-04 9:30 ` Lesly Arackal Manuel
2010-11-04 9:38 ` Lesly Arackal Manuel
2010-11-06 11:54 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0680EC522D0CC943BC586913CF3768C003FF2DAF9D@dbde02.ent.ti.com \
--to=rnayak@ti.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ext-juha.1.keski-saari@nokia.com \
--cc=leslyam@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®