From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2315A23B605 for ; Sun, 9 Nov 2025 23:17:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762730246; cv=none; b=cAw9pkn5h1+lqCR2SgcbUHp1QIMMCSfWTN1WmLG9tDnq9utGDjmlbhNgHIvqrv3nxgRuPiIYH4Vm59IIXV/PzDEzchFth++t5ADT2bb8pik+WFs5BUK6HaqmAoK66OPnRHbTpmH9b83suU8xNWb4xH33J8aEJGKB4x/1MtytVsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762730246; c=relaxed/simple; bh=9HPccSaRODowbMJetF9HS+q1lefUwxe9mdTxG+/vhyQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Nrl+SPmYsSpd/lxxaz8vruAL9UWCfp581vROLiFrbkEB/HPMWHGOBU0R9AocVfAuuLS8x47/Buas3DrAgtVnITpZMvcjdEy+v6y3oNkBdNGrKzFJfTCh2zWYjomPvGcoUBrC7CA7zQgchclt8yQpFnG5tYbO/xfTTfNhPhCD0/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NhpxwZ8B; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=r1uediy2; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NhpxwZ8B"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="r1uediy2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762730244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rSDHOW5XasPVJqQA0pLiGIBUxgDXQ6cYHB9Lnz+lgvk=; b=NhpxwZ8B3Fu+411RlqlIe72LbRQMCq4V03F1M0m5KLv8o3l4/uWmKN4/XLBcCacI21g1hA w4+aMAls9EED+ym4VVnNKMMTbEI3Lks8o48QSrpuMEbQcjChnIc11iDLstvgFPzu7XwQL7 q3wc6oBtt93Mxw6ZD0YTcwKCf7SYtgA= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-5hfYIaHxOeuExyn9BuNMiw-1; Sun, 09 Nov 2025 18:17:22 -0500 X-MC-Unique: 5hfYIaHxOeuExyn9BuNMiw-1 X-Mimecast-MFC-AGG-ID: 5hfYIaHxOeuExyn9BuNMiw_1762730241 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7b0a870d3ebso2392449b3a.3 for ; Sun, 09 Nov 2025 15:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762730241; x=1763335041; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rSDHOW5XasPVJqQA0pLiGIBUxgDXQ6cYHB9Lnz+lgvk=; b=r1uediy2qQtwLAqRsY66nmNKoJuEWGHWBuYW1+EVOFzZNAGrSxuM0ufISN9CCQzgyv z5zjIbfwd5qzA3gXUWSh83ll3K3e0njyG8NHPjGlmwIfmml3O+9FmS0sBDSu8MC8ZrHV 0zVQLRAedFi8lvoS514LCaE+WIYV5j00bo+15KXKM3VjQ5TZb8NkNeK6WeM9bNud9gw5 D98IoEfWKJfEIQhqOdUPaWnVIKA3/nDBrIO4x5p6IQz/2QJ1DmD4OyjrtnCbGbjFKe62 joZC1b9ziZ897leMKffz4g1oGaXNAvRizi8o04NF+O1isGLc/sxpMSZ77lTPZiS1U1gW 7QNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762730241; x=1763335041; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rSDHOW5XasPVJqQA0pLiGIBUxgDXQ6cYHB9Lnz+lgvk=; b=Df65t+s9t93mISF53rq/x8KYCraYDrjqzin8pTqBjC6CdJ5PbnustfO1f25ZtcE+MB jj+vr0bj42TVrAYin0dbCeueYoFjEiNMB8TEYxTtkrbYY1Q3ywe1jPBzhN8ny7GBxLzW IGxiNo79T3PLTQIJNxibCYRlOWHJs1m1H63fZAVOjg7NxSy1nJL+b2cSu6PzEDfBnVON f7kNAMhxF12PQF8llXfcghDfcoSd5N+uGYZG5J/Y+2ue+NFrjrRCV+918fXVgFqysTOS GX3cV4P8Cv7DqjC1ZEuQbAE3R58aQK5/JP/ZYnWMyaLIcGhvb4Dbdp96bFDdH1SvYdxi D2WA== X-Forwarded-Encrypted: i=1; AJvYcCXVryTbSTTmGXwqcJjq4pPuhD3k3tTx8mhqk5G0sND+IEaR/ojdhLHYcL0xRCDw+F2CN6GDnvvfo6Dh/j4=@vger.kernel.org X-Gm-Message-State: AOJu0YzoqDcGSz2PQj4Qzy/rjnU+F9a/2+//pH49N/QNxC/jnLIM8S2s 3FA1bR3tSn3wxFKizzs7QpRFHCln2zpTIQVTFr5k5tmAwH4UUkubxoqRdMLBwZif4tvKyPZIZ3b J/R+od+Cowck3GJ2cMUDRJmSGxyFQZLGYrhapAZtARqzuxNzRDE/i+hLkMEp66+iyXw== X-Gm-Gg: ASbGnctDaohJ24ZAwocX/qHF8Wh4g6jfjMYZK/jFctp2xTdZ7Ctzq2UpX+oCKbS3STb icDcyW9z8T/2o0Jpu9YnCzWBen2+AbCYt+mJOa7REoZOF8kGsElAGMwRD5sjuzYx7EuOtFhc5aS VL2n0enyJMYSxhRsqO5NKDBh7mN+YMh461MwF71Kp/Vv9mar4u5HgtUxSiKVc7rVTisinlVjk23 CChXQVQaVSVPCQtcK9at01KfYdmA97Koj2tzwP0r/cp+9fQXHU/Db9mN+skFcQ2J1Zt1GXNfTYf pJgIJ1bPyhHEnISqZZWjLVPHIe9RgqfKgPWuoh2+WWDxVMvzfzsU/TKzGb3+4H0Y8J+LyMYDDka TXo4WpwlD6A3PU8iH1CEKCcKE7e7q6C+L/yQ6Q5s= X-Received: by 2002:a05:6a00:92a5:b0:7a5:9cf5:b34c with SMTP id d2e1a72fcca58-7b22699a31bmr6235505b3a.23.1762730241531; Sun, 09 Nov 2025 15:17:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyJ8mJuDYzT0bH6fnz8FfZfCseiPLOpolrjUCoQmaU79/ynR3kBTkMtZAcp2qilkrB0mYBjw== X-Received: by 2002:a05:6a00:92a5:b0:7a5:9cf5:b34c with SMTP id d2e1a72fcca58-7b22699a31bmr6235495b3a.23.1762730241214; Sun, 09 Nov 2025 15:17:21 -0800 (PST) Received: from [192.168.68.51] (n175-34-62-5.mrk21.qld.optusnet.com.au. [175.34.62.5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b0ccc59e44sm9611875b3a.64.2025.11.09.15.17.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Nov 2025 15:17:20 -0800 (PST) Message-ID: <06833ea2-0f9a-4429-8f29-4a41f462c0c9@redhat.com> Date: Mon, 10 Nov 2025 09:17:07 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 30/33] arm_mpam: Use long MBWU counters if supported To: Ben Horgan , james.morse@arm.com Cc: amitsinght@marvell.com, baisheng.gao@unisoc.com, baolin.wang@linux.alibaba.com, bobo.shaobowang@huawei.com, carl@os.amperecomputing.com, catalin.marinas@arm.com, dakr@kernel.org, dave.martin@arm.com, david@redhat.com, dfustini@baylibre.com, fenghuay@nvidia.com, gregkh@linuxfoundation.org, guohanjun@huawei.com, jeremy.linton@arm.com, jonathan.cameron@huawei.com, kobak@nvidia.com, lcherian@marvell.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lpieralisi@kernel.org, peternewman@google.com, quic_jiles@quicinc.com, rafael@kernel.org, robh@kernel.org, rohit.mathew@arm.com, scott@os.amperecomputing.com, sdonthineni@nvidia.com, sudeep.holla@arm.com, tan.shaopeng@fujitsu.com, will@kernel.org, xhao@linux.alibaba.com, Shaopeng Tan References: <20251107123450.664001-1-ben.horgan@arm.com> <20251107123450.664001-31-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20251107123450.664001-31-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/7/25 10:34 PM, Ben Horgan wrote: > From: Rohit Mathew > > Now that the larger counter sizes are probed, make use of them. > > Callers of mpam_msmon_read() may not know (or care!) about the different > counter sizes. Allow them to specify mpam_feat_msmon_mbwu and have the > driver pick the counter to use. > > Only 32bit accesses to the MSC are required to be supported by the > spec, but these registers are 64bits. The lower half may overflow > into the higher half between two 32bit reads. To avoid this, use > a helper that reads the top half multiple times to check for overflow. > > Signed-off-by: Rohit Mathew > [morse: merged multiple patches from Rohit, added explicit counter selection ] > Signed-off-by: James Morse > Reviewed-by: Ben Horgan > Reviewed-by: Jonathan Cameron > Reviewed-by: Fenghua Yu > Tested-by: Fenghua Yu > Cc: Peter Newman > Tested-by: Shaopeng Tan > Signed-off-by: Ben Horgan > --- > Changes since v3: > Peter: > Fix type checking, use mpam_feat_msmon_mbwu_counter > Reset/configuration order of long counters > --- > drivers/resctrl/mpam_devices.c | 145 ++++++++++++++++++++++++++++----- > 1 file changed, 126 insertions(+), 19 deletions(-) > Reviewed-by: Gavin Shan