mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Hahn <B.Hahn@phytec.de>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Yannic Moog <y.moog@phytec.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	upstream@lists.phytec.de
Subject: Re: [PATCH v2 3/5] arm64: dts: imx95-phyflex-libra-rdk: Add overlays
Date: Tue, 17 Nov 2026 10:32:25 +0100	[thread overview]
Message-ID: <06904f2c-379b-412a-a842-04d7898c56d4@phytec.de> (raw)
In-Reply-To: <avc7o0T0-tSW_c0H@SMW015318>

Am 13.11.26 um 17:32 schrieb Frank Li:
> On Fri, Nov 13, 2026 at 05:00:05PM +0100, Benjamin Hahn wrote:
>
> subject Add overlay for som temperature sensors and ...
>
>> Add overlays for SoM temperature sensors and M.2 Key-E WIFI/BT cards
>> that need the nxp,88w8987-bt compatible in devicetree (tested on
>> IW611/IW612).
>>
>> Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
>> ---
>>   arch/arm64/boot/dts/freescale/Makefile             |  9 ++++++++
>>   .../imx95-phyflex-fpsc-g-som-temperature.dtso      | 23 +++++++++++++++++++++
>>   .../imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso | 24 ++++++++++++++++++++++
> which is independ, suggest use two patches to do that.
Will do
>
>>   3 files changed, 56 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
>> index 4eb7508193e7..17b357f4886a 100644
>> --- a/arch/arm64/boot/dts/freescale/Makefile
>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>> @@ -739,7 +739,16 @@ imx95-19x19-evk-pcie1-ep-dtbs += imx95-19x19-evk.dtb imx-pcie1-ep.dtbo
>>   dtb-$(CONFIG_ARCH_MXC) += imx95-19x19-evk-pcie0-ep.dtb imx95-19x19-evk-pcie1-ep.dtb
>>   dtb-$(CONFIG_ARCH_MXC) += imx95-libra-rdk-fpsc.dtb
>>
>> +imx95-phyflex-fpsc-g-som-temperature-dtbs := \
>> +			  imx95-phyflex-libra-rdk.dtb \
>> +			  imx95-phyflex-fpsc-g-som-temperature.dtbo
>> +imx95-phyflex-libra-rdk-bluetooth-88w8987-dtbs := \
>> +			  imx95-phyflex-libra-rdk.dtb \
>> +			  imx95-phyflex-libra-rdk-bluetooth-88w8987.dtbo
>> +
>>   dtb-$(CONFIG_ARCH_MXC) += imx95-phyflex-libra-rdk.dtb
>> +dtb-$(CONFIG_ARCH_MXC) += imx95-phyflex-fpsc-g-som-temperature.dtb
>> +dtb-$(CONFIG_ARCH_MXC) += imx95-phyflex-libra-rdk-bluetooth-88w8987.dtb
>>
>>   dtb-$(CONFIG_ARCH_MXC) += imx95-19x19-verdin-evk.dtb
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx95-phyflex-fpsc-g-som-temperature.dtso b/arch/arm64/boot/dts/freescale/imx95-phyflex-fpsc-g-som-temperature.dtso
>> new file mode 100644
>> index 000000000000..84afe1ff9f06
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/imx95-phyflex-fpsc-g-som-temperature.dtso
>> @@ -0,0 +1,23 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (C) 2026 PHYTEC Messtechnik GmbH
>> + */
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +&dram_sense {
>> +	status = "okay";
>> +};
>> +
>> +&emmc_sense {
>> +	status = "okay";
>> +};
>> +
>> +&ethphy_sense {
>> +	status = "okay";
>> +};
>> +
>> +&pmic_sense {
>> +	status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso b/arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso
>> new file mode 100644
>> index 000000000000..1601e04b3940
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso
>> @@ -0,0 +1,24 @@
>> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
>> +/*
>> + * Copyright (C) 2026 PHYTEC Messtechnik GmbH
>> + */
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +&lpuart8 {
>> +	bluetooth {
> Can you add label for bluetooth at boards file, so this overlay can
> reuse for other 88w8987-bt module.
This would be technically possible, but I don't think it is the cleanest 
solution.
1. adding an empty bluetooth node into the base dts leads to DTBS_CHECK 
errors:

arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk.dtb: 
serial@426a0000 (fsl,imx95-lpuart): bluetooth: 'compatible' is a 
required property
         from schema $id: 
http://devicetree.org/schemas/serial/fsl-lpuart.yaml
arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk.dtb: 
serial@426a0000 (fsl,imx95-lpuart): Unevaluated properties are not 
allowed ('bluetooth', 'uart-has-rtscts' were unexpected)
         from schema $id: 
http://devicetree.org/schemas/serial/fsl-lpuart.yaml
arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk.dtb: 
serial@426a0000 (fsl,imx95-lpuart): bluetooth: 'compatible' is a 
required property
         from schema $id: http://devicetree.org/schemas/serial/serial.yaml

2. I also think this is a bit missleading, as this UART is not used fix 
for bluetooth on M.2 Key-E, but its default is RS232/RS485. It can be 
switched to Key-E by the Multiplexer controlled by UART1_BT_RS_SEL GPIO.

The (default) state of this GPIO also needs to  be switched when 
enabling this overlay. So this leads to the overlay not beeing generic 
anyway.

>
>> +		compatible = "nxp,88w8987-bt";
>> +		fw-init-baudrate = <115200>;
>> +	};
>> +};
>> +
>> +&gpio_expander1 {
>> +	uart1_bt_rs_sel: bt-rs-hog {
>> +		gpios = <14 GPIO_ACTIVE_HIGH>;
>> +		gpio-hog;
> Look like it is pinmux ref gpio-mux
>
> https://lore.kernel.org/imx/20261023-dxl_lcdif-v4-5-4ae8395a4b23@nxp.com/

Looks like a good solution, will do.

Benjamin

>
> Frank
>> +		line-name = "UART1_BT_RS_SEL";
>> +		output-high;
>> +	};
>> +};
>>
>> --
>> 2.53.0
>>
>>

  reply	other threads:[~2026-11-17  9:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 16:00 [PATCH v2 0/5] arm64: dts: update imx95 Libra for the newest hardware version Benjamin Hahn
2026-11-13 16:00 ` [PATCH v2 1/5] dt-bindings: arm: fsl: Add phyFLEX-i.MX 95 Libra RDK Benjamin Hahn
2026-11-13 16:48   ` Conor Dooley
2026-11-13 16:00 ` [PATCH v2 2/5] arm64: dts: imx95-phyflex-libra-rdk: " Benjamin Hahn
2026-11-13 16:00 ` [PATCH v2 3/5] arm64: dts: imx95-phyflex-libra-rdk: Add overlays Benjamin Hahn
2026-11-13 16:32   ` Frank Li
2026-11-17  9:32     ` Benjamin Hahn [this message]
2026-11-13 16:00 ` [PATCH v2 4/5] arm64: dts: imx95-libra-rdk-fpsc: remove devicetree for old Libra Benjamin Hahn
2026-11-13 16:00 ` [PATCH v2 5/5] dt-bindings: arm: fsl: remove outdated PHYTEC i.MX95 FPSC Benjamin Hahn
2026-11-13 16:48   ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06904f2c-379b-412a-a842-04d7898c56d4@phytec.de \
    --to=b.hahn@phytec.de \
    --cc=Frank.Li@nxp.com \
    --cc=Frank.li@oss.nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=upstream@lists.phytec.de \
    --cc=y.moog@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®