From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95052495047 for ; Fri, 14 Aug 2026 19:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786734350; cv=none; b=IWGuER+36y1lmMRzx0rXJoK/dlGBj4BmpvGRxMf3PSA2qoXG3A6OLEATDYm3Jeq+eTrhnbPm+IDnh8hG6ZHPaVKRvb3OOXfi4CiUoKtqbhbbaVXJqGZL9yJkUCaoCUbKdrEqGpZEu5mjY3ePH9uwgB9W1XXERBw0VYdL9xAHUC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786734350; c=relaxed/simple; bh=0emCMbJ+h2nCMEroPXBzDZ3EPNgPaeMCWaMxB84CAGo=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=tQiXYQv8t6KHtsKC6JpZ1CX8IoR+c/XMLZyOkjZ+pT+G23VK+K8yniO+f89DFWnGRqhqzqbCzpTq+wVW55JHyYfx3jbflC0SQoWNtdDIFU2EhcRmJPiMMN2YdCZVSmwu7hOyXSuqsPwnYgtZ9oyHQq5l3m7EOaem4lKdbVnGCVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LCkyhVMe; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LCkyhVMe" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8486672f03cso1351076b3a.0 for ; Fri, 14 Aug 2026 12:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786734349; x=1787339149; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QAXKRxocIivx4YgW8+hRQ+MEsaA4qCcbwHNF7u6hZb4=; b=LCkyhVMeJ6WTNbSYvRdpt5rWg7DFiWFkDaPk04kPGdYm9jXUqZTChnVpOXNSWuS+9m QojDoBF+A4MhaAlrZAUlMLY9f5iAopWqKsIOtlZxnhrLN8TIF3NxdoitU+05oi3VWt6C o0ZfL9PlFZZcHmNeZoBtZ9raJmLG/nprUtz0teAnNgcJhZMxEJ5ACX910xfKGH/EsyoK dH8lqL31+SL4vhoKHPqj+ne2vfmhKqVV8LUAZGqbOzAX9lZsX7YVi++WY2isWJUVQCUV gPKZKhCgr7dvxFFdG15VUfo9GWJ750L4pf2egS7BA/RvKWgVMhtIS/4LeAkBnD4N+iyj PSAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786734349; x=1787339149; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QAXKRxocIivx4YgW8+hRQ+MEsaA4qCcbwHNF7u6hZb4=; b=ApUDizgCVa7JmevJ3DtvkEvRGglyKCSHEtYcx9xA4AnyyTeZbBePqVDGuM+rIPUJEq mJ5Fib6U5FVUPcN5caCD1svOA7gOgBXLDmdN/G3oH1FnTBsbmU92KGtmO3iwpw6rdhPY 9lsb3Mfgy3cmB9cUUpsXO7dRtzwZUtNFhtdikEh9eUgh0pJeO/BidPytsXNAmT50QRwS DzYaEbY5T2VLLE+O3w3/Ce6CCgzY1fAd+DRdH5FC73l41yRwh3j3aElNxIYXm4Lcyh7V 49tdR7pAR4Zr8mbJAlUM0qJ4yaQzajJrVIx3lloZa9tBUomyFCRX2U350mkyEoVEwrSO In+w== X-Forwarded-Encrypted: i=1; AHgh+RqxUVBUjLuDeiTqwPQTBZGsiB1H7VMoqC52Jigbbg28VDsN3IprMsDAZzXoauGUvKsy5xFKpEndOBpZWF8=@vger.kernel.org X-Gm-Message-State: AOJu0YzquAhwH64IimZuPahuAm7t2HUKu/8cKf4y5k3iymQXEvAbYx6U fyTGlPaHvVy92+4VcnwIxpTYKu2wvSw4pPhSPQqbK6EDzfWlkjNYBDIX X-Gm-Gg: AR+sD12UwQ3G0pzZ4J6U+49YCufbgno3bAEWzZfhaW5xsuAiHvZO3SxtxNh9ygGLzCD okzTrFs7Pr1KErUlzubJR0P0bFk51tPVoN/dIsPNvmLB+HyER8TAeEZacSQ3EzY+MlDJeFH0QA2 aH9EEozi3t8BZihl3t7tNqceZM79poq5TVrF2NbOftWgYjXB9wR4UncoAmkyGvxbAc4QHJ5aAl5 voEeHdZ65UU/RatjLf+n2641MleJuivSFJpMzOZc6KSe7sfZFcUK1MhkmUJaS0/VNLTsdaazIB7 BOlZzSqd7u6uinC8Z9A9mEVA/juatg4Kh8FfT4W7W+s0YzbENS7YgvBHxIlDdvkGl6p2lOE0peM uU/g1ict7+upOUaWgk3UjS1nAnzR6oQWGgDFu/ZiCHu6DE17FodUy91Hdp2Ch4FT1JmL7qw4Rn8 e8kzqg6xtq3BojxVW+vzft6yEzYvRdl61FyurgCbx8mHkUHobPWoMPro2WxjajkHAssRbrVxaTv /3Kl+K1Rrsdfbe9BGRRmqTAmM5NGlrFnuP6ClY= X-Received: by 2002:a05:6a00:a24c:b0:84f:a170:4f5b with SMTP id d2e1a72fcca58-84fddfa857bmr9177392b3a.8.1786734348789; Fri, 14 Aug 2026 12:05:48 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8517d26726bsm891800b3a.54.2026.08.14.12.05.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 12:05:48 -0700 (PDT) Sender: Guenter Roeck Message-ID: <069440f6-1863-4767-af50-698fb328fd8d@roeck-us.net> Date: Fri, 14 Aug 2026 12:05:46 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] erofs: cap LZMA stream pool size To: Geert Uytterhoeven , Gao Xiang , Michael Bommarito , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , SJ Park , Gao Xiang , Yue Hu , Jeffle Xu , Sandeep Dhavale , Chunhai Guo , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Chao Yu , David Hildenbrand , linux-kbuild References: <87853c96-cc8f-49e6-81b1-02bfe409e372@roeck-us.net> <5825b5c2-06b3-4358-91b0-d7bf437528a3@roeck-us.net> <1638f2a8-d9cd-423d-83f6-2b436e3c9de0@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/14/26 11:50, Gao Xiang wrote: > On Fri, Aug 14, 2026 at 11:44:31AM -0700, Guenter Roeck wrote: >> On 8/14/26 11:26, Gao Xiang wrote: >>> Hi Guenter, >>> >>> On Wed, Aug 12, 2026 at 07:25:50AM -0700, Guenter Roeck wrote: >>> >>> ... >>> >>>>>> >>>>>> Thank you, that seems to work (despite still seeing the warning on m68k, >>>>>> as NR_CPUS does not exist). >>>>>> >>>>> >>>>> ... >>>>> >>>>>> >>>>>> $ make ARCH=m68k allmodconfig >>>>>> fs/erofs/Kconfig:137:warning: range is invalid >>>>>> >>>>>> Warning... >>>>>> >>>>> >>>>> Yes, other arches shouldn't have the warning because I think other >>>>> arches (including microblaze) defines NR_CPUS in Kconfig, except m68k. >>>>> >>>> >>>> That is not entirely true. openrisc only has it if SMP=y. But it still >>>> does not generate the warning for some reason. >>>> >>> >>> I looked into the documentation a bit >>> (https://docs.kernel.org/kbuild/kconfig-language.html), especially the >>> following parts: >>> >>> - type definition: “bool”/”tristate”/”string”/”hex”/”int” ... >>> - input prompt: “prompt” [“if” ] ... >>> and "If a prompt is not present, the config option is >>> a non-visible symbol, ..." >>> >>> - dependencies: “depends on” [“if” ] ... >>> - Menu dependencies .. >>> >>> and I think that is true, taking openrisc for example: >>> >>> config NR_CPUS >>> int "Maximum number of CPUs (2-32)" >>> range 2 32 >>> depends on SMP >>> default "2" >>> >>> which can be transformed into >>> >>> config NR_CPUS >>> int >>> prompt "Maximum number of CPUs (2-32)" >>> range 2 32 >>> depends on SMP >>> default "2" >>> >>> which can be then transformed into >>> >>> config NR_CPUS >>> int >>> prompt "Maximum number of CPUs (2-32)" if SMP >>> range 2 32 if SMP >>> default "2" if SMP >>> >>> so if `SMP=n`, it's equivalent to >>> >>> config NR_CPUS >>> int >>> >>> so NR_CPUS symbol is still there I think (and its value is 0.) >>> >> $ grep NR_CPUS .config >> CONFIG_FORCE_NR_CPUS=y >> $ grep EROFS .config >> CONFIG_EROFS_FS=y >> # CONFIG_EROFS_FS_DEBUG is not set >> CONFIG_EROFS_FS_XATTR=y >> CONFIG_EROFS_FS_POSIX_ACL=y >> CONFIG_EROFS_FS_SECURITY=y >> CONFIG_EROFS_FS_BACKED_BY_FILE=y >> CONFIG_EROFS_FS_ZIP=y >> CONFIG_EROFS_FS_ZIP_LZMA=y >> CONFIG_EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS=0 >> # CONFIG_EROFS_FS_ZIP_DEFLATE is not set >> # CONFIG_EROFS_FS_ZIP_ZSTD is not set >> # CONFIG_EROFS_FS_ZIP_ACCEL is not set >> # CONFIG_EROFS_FS_PCPU_KTHREAD is not set >> # CONFIG_EROFS_FS_PAGE_CACHE_SHARE is not set >> >> The symbol may be there internally, but it does not show up in .config. > > As I said, the documentation: > > If a prompt is not present, the config option is > a non-visible symbol, meaning its value cannot be > directly changed by the user (such as altering the > value in .config) and the option will not appear in > any config menus. > > So It think it's expected, and any config X like > this won't be shown in .config: > > config X > int > Ah, yes, that makes sense. Thanks, Guenter